From: Christoph Hellwig <hch@infradead.org>
To: Jan Kara <jack@suse.cz>
Cc: Ted Tso <tytso@mit.edu>,
linux-ext4@vger.kernel.org, Christoph Hellwig <hch@infradead.org>,
stable@vger.kernel.org
Subject: Re: [PATCH] jbd2: Fix dbench4 performance regression for 'nobarrier' mounts
Date: Fri, 28 Apr 2017 08:03:24 -0700 [thread overview]
Message-ID: <20170428150324.GA20122@infradead.org> (raw)
In-Reply-To: <20170428095934.11583-1-jack@suse.cz>
On Fri, Apr 28, 2017 at 11:59:34AM +0200, Jan Kara wrote:
> Fix the problem by making sure journal superblock writes are always
> treated as synchronous since they generally block progress of the
> journalling machinery and thus the whole filesystem.
The callchains leading down to jbd2_write_superblock looks a little
suspicious to me. It seems like jbd2_journal_commit_transaction
will actually call without FUA in the JBD2_FLUSHED case. Is that
really intentional, and if yes should it be documented?
Except for that it would seem more useful to move to a "bool preflush"
argument passed down.
But I guess we'll need a quick fix first, for that:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2017-04-28 15:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-28 9:59 [PATCH] jbd2: Fix dbench4 performance regression for 'nobarrier' mounts Jan Kara
2017-04-28 15:03 ` Christoph Hellwig [this message]
2017-05-02 9:36 ` Jan Kara
2017-04-30 1:14 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170428150324.GA20122@infradead.org \
--to=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox