From: Lukas Czerner <lczerner@redhat.com>
To: Theodore Ts'o <tytso@mit.edu>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH 1/2] ext4: no need to cond_resched() in ext4_trim_all_free()
Date: Thu, 4 May 2017 13:19:16 +0200 [thread overview]
Message-ID: <20170504111916.2y4ali7kk6twij5n@localhost.localdomain> (raw)
In-Reply-To: <20170430042605.v3myihn2x4lolmso@thunk.org>
On Sun, Apr 30, 2017 at 12:26:05AM -0400, Theodore Ts'o wrote:
> On Thu, Apr 27, 2017 at 10:36:40AM +0200, Lukas Czerner wrote:
> > There is no need to call cond_resched() in ext4_trim_all_free() since
> > blkdev_issue_discard() already takes care of that. So just remove it.
>
> Actually, it could be needed. If minblocks is a small value, say 2,
> and every other block in file system is allocated, then we could be in
> the while loop for a long time. That's a pretty unusual case, but
> it's good to have the need_resched() check there.
>
> - Ted
Fair enough, it's unusuall case, but still possible. Let's keep it this
way.
Thanks!
-Lukas
prev parent reply other threads:[~2017-05-04 11:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-27 8:36 [PATCH 1/2] ext4: no need to cond_resched() in ext4_trim_all_free() Lukas Czerner
2017-04-30 4:26 ` Theodore Ts'o
2017-05-04 11:19 ` Lukas Czerner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170504111916.2y4ali7kk6twij5n@localhost.localdomain \
--to=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox