From: Jan Kara <jack@suse.cz>
To: Michal Hocko <mhocko@kernel.org>
Cc: Tahsin Erdogan <tahsin@google.com>, Theodore Ts'o <tytso@mit.edu>,
Jan Kara <jack@suse.com>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] jbd2: preserve original nofs flag during journal restart
Date: Thu, 18 May 2017 11:39:39 +0200 [thread overview]
Message-ID: <20170518093939.GD9084@quack2.suse.cz> (raw)
In-Reply-To: <20170518091253.GE25462@dhcp22.suse.cz>
On Thu 18-05-17 11:12:53, Michal Hocko wrote:
> On Wed 17-05-17 09:16:29, Tahsin Erdogan wrote:
> [...]
> > diff --git a/fs/jbd2/transaction.c b/fs/jbd2/transaction.c
> > index 9ee4832b6f8b..05c0323493fb 100644
> > --- a/fs/jbd2/transaction.c
> > +++ b/fs/jbd2/transaction.c
> > @@ -680,6 +680,8 @@ int jbd2__journal_restart(handle_t *handle, int nblocks, gfp_t gfp_mask)
> >
> > rwsem_release(&journal->j_trans_commit_map, 1, _THIS_IP_);
> > handle->h_buffer_credits = nblocks;
> > + /* Restore original nofs flag as jbd2_journal_stop() would do. */
>
> I was thinking something more specific like
> /*
> * Restore the original nofs context because the journal restart
> * is basically the same thing as journal stop and start.
> * start_this_handle will start a new nofs context.
> */
Yeah, this is much better. Tahsin, please use Michal's version. Thanks!
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2017-05-18 9:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-17 12:33 [PATCH] jbd2: preserve original nofs flag during journal restart Tahsin Erdogan
2017-05-17 14:04 ` Jan Kara
2017-05-17 14:13 ` Michal Hocko
2017-05-17 14:56 ` Jan Kara
2017-05-17 15:24 ` Michal Hocko
2017-05-17 16:16 ` [PATCH v2] " Tahsin Erdogan
2017-05-18 9:12 ` Michal Hocko
2017-05-18 9:39 ` Jan Kara [this message]
2017-05-18 16:28 ` [PATCH v3] " Tahsin Erdogan
2017-05-20 4:09 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170518093939.GD9084@quack2.suse.cz \
--to=jack@suse.cz \
--cc=jack@suse.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhocko@kernel.org \
--cc=tahsin@google.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox