From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kara Subject: [PATCH 2/2] ext4: Fix off-by-in in loop termination in ext4_find_unwritten_pgoff() Date: Thu, 18 May 2017 12:49:42 +0200 Message-ID: <20170518104942.14588-3-jack@suse.cz> References: <20170518104942.14588-1-jack@suse.cz> Cc: , Jan Kara To: Ted Tso Return-path: Received: from mx2.suse.de ([195.135.220.15]:47723 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932288AbdERKty (ORCPT ); Thu, 18 May 2017 06:49:54 -0400 In-Reply-To: <20170518104942.14588-1-jack@suse.cz> Sender: linux-ext4-owner@vger.kernel.org List-ID: There is an off-by-one error in loop termination conditions in ext4_find_unwritten_pgoff() since 'end' may index a page beyond end of desired range if 'endoff' is page aligned. It doesn't have any visible effects but still it is good to fix it. Signed-off-by: Jan Kara --- fs/ext4/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ext4/file.c b/fs/ext4/file.c index bbea2dccd584..2b00bf84c05b 100644 --- a/fs/ext4/file.c +++ b/fs/ext4/file.c @@ -474,7 +474,7 @@ static int ext4_find_unwritten_pgoff(struct inode *inode, endoff = (loff_t)end_blk << blkbits; index = startoff >> PAGE_SHIFT; - end = endoff >> PAGE_SHIFT; + end = (endoff - 1) >> PAGE_SHIFT; pagevec_init(&pvec, 0); do { -- 2.12.0