Re: [PATCH v2] jbd2: preserve original nofs flag during journal restart

Michal Hocko
2017-05-18T09:13:01Z

On Wed 17-05-17 09:16:29, Tahsin Erdogan wrote:
[...]
> diff --git a/fs/jbd2/transaction.c b/fs/jbd2/transaction.c
> index 9ee4832b6f8b..05c0323493fb 100644
> --- a/fs/jbd2/transaction.c
> +++ b/fs/jbd2/transaction.c
> @@ -680,6 +680,8 @@ int jbd2__journal_restart(handle_t *handle, int nblocks, gfp_t gfp_mask)
>
> rwsem_release(&journal->j_trans_commit_map, 1, _THIS_IP_);
> handle->h_buffer_credits = nblocks;
> + /* Restore original nofs flag as jbd2_journal_stop() would do. */

I was thinking something more specific like
/*
* Restore the original nofs context because the journal restart
* is basically the same thing as journal stop and start.
* start_this_handle will start a new nofs context.
*/
> + memalloc_nofs_restore(handle->saved_alloc_context);
> ret = start_this_handle(journal, handle, gfp_mask);
> return ret;
> }
> --
> 2.13.0.303.g4ebf302169-goog
>

--
Michal Hocko
SUSE Labs