From: Theodore Ts'o <tytso@mit.edu>
To: Jan Kara <jack@suse.cz>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH 2/2] ext4: Fix off-by-in in loop termination in ext4_find_unwritten_pgoff()
Date: Sat, 20 May 2017 00:15:34 -0400 [thread overview]
Message-ID: <20170520041534.25req27q6epii3rr@thunk.org> (raw)
In-Reply-To: <20170518104942.14588-3-jack@suse.cz>
On Thu, May 18, 2017 at 12:49:42PM +0200, Jan Kara wrote:
> There is an off-by-one error in loop termination conditions in
> ext4_find_unwritten_pgoff() since 'end' may index a page beyond end of
> desired range if 'endoff' is page aligned. It doesn't have any visible
> effects but still it is good to fix it.
>
> Signed-off-by: Jan Kara <jack@suse.cz>
Thanks, applied.
- Ted
next prev parent reply other threads:[~2017-05-20 4:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-18 10:49 [PATCH 0/2 v3] ext4: Fix SEEK_HOLE implementation Jan Kara
2017-05-18 10:49 ` [PATCH 1/2] ext4: Fix SEEK_HOLE Jan Kara
2017-05-20 4:14 ` Theodore Ts'o
2017-05-18 10:49 ` [PATCH 2/2] ext4: Fix off-by-in in loop termination in ext4_find_unwritten_pgoff() Jan Kara
2017-05-20 4:15 ` Theodore Ts'o [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-05-17 12:07 [PATCH 0/2 v2] ext4: Fix SEEK_HOLE implementation Jan Kara
2017-05-17 12:07 ` [PATCH 2/2] ext4: Fix off-by-in in loop termination in ext4_find_unwritten_pgoff() Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170520041534.25req27q6epii3rr@thunk.org \
--to=tytso@mit.edu \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox