From: Theodore Ts'o <tytso@mit.edu>
To: Konstantin Chistyakov <Konstantin.Chistyakov@paragon-software.com>
Cc: "linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>
Subject: Re: libext2fs: don't flush to device opened in read-only mode
Date: Wed, 24 May 2017 17:56:22 -0400 [thread overview]
Message-ID: <20170524215622.fh7yin4fttggw36f@thunk.org> (raw)
In-Reply-To: <118AAB5F26BFB34DB5CDA7DA33334DB9B5FF41@vmsk-exch-01.paragon-software.com>
On Mon, May 22, 2017 at 09:48:00AM +0000, Konstantin Chistyakov wrote:
> From: Konstantin Chistyakov <Konstantin.Chistyakov@Paragon-software.com>
> Date: Tue, 19 May 2017 09:23:29 -0600
> Subject: [PATCH] libext2fs: don't flush to device opened in read-only mode
>
> From: Konstantin Chistyakov <Konstantin.Chistyakov@Paragon-software.com>
>
> If the e2fsck is called with both -f -n options, the checking completing with a flushing error (retcode 8).
>
> Catch error from the unix_flush() fsync(data->dev) when data->dev is opened in read-only mode:
I can't reproduce this problem. What storage device or operating
system are you using?
That being said, this is probably the wrong place to fix it. The
better fix is in e2fsck/unix.c, by adding a read-only test.
- Ted
next prev parent reply other threads:[~2017-05-24 21:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-22 9:48 [PATCH] libext2fs: don't flush to device opened in read-only mode Konstantin Chistyakov
2017-05-24 21:56 ` Theodore Ts'o [this message]
2017-05-25 5:50 ` Konstantin Chistyakov
2017-05-25 12:12 ` Konstantin Chistyakov
2017-05-29 23:43 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170524215622.fh7yin4fttggw36f@thunk.org \
--to=tytso@mit.edu \
--cc=Konstantin.Chistyakov@paragon-software.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox