From: Theodore Ts'o <tytso@mit.edu>
To: Tahsin Erdogan <tahsin@google.com>
Cc: Andreas Dilger <adilger.kernel@dilger.ca>,
Jan Kara <jack@suse.cz>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] ext4: fix quota charging for shared xattr blocks
Date: Wed, 24 May 2017 18:25:41 -0400 [thread overview]
Message-ID: <20170524222541.bmefxdhbdhle4in2@thunk.org> (raw)
In-Reply-To: <20170524113519.16232-1-tahsin@google.com>
On Wed, May 24, 2017 at 04:35:19AM -0700, Tahsin Erdogan wrote:
> ext4_xattr_block_set() calls dquot_alloc_block() to charge for an xattr
> block when new references are made. However if dquot_initialize() hasn't
> been called on an inode, request for charging is effectively ignored
> because ext4_inode_info->i_dquot is not initialized yet.
>
> Add dquot_initialize() to call paths that lead to ext4_xattr_block_set().
>
> Signed-off-by: Tahsin Erdogan <tahsin@google.com>
> Reviewed-by: Jan Kara <jack@suse.cz>
Applied, thanks.
- Ted
prev parent reply other threads:[~2017-05-24 22:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-23 3:01 [PATCH] ext4: fix quota charging for shared xattr blocks Tahsin Erdogan
2017-05-23 8:10 ` Jan Kara
2017-05-23 23:03 ` [PATCH v2] " Tahsin Erdogan
2017-05-24 9:06 ` Jan Kara
2017-05-24 11:35 ` [PATCH v3] " Tahsin Erdogan
2017-05-24 22:25 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170524222541.bmefxdhbdhle4in2@thunk.org \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tahsin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox