From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH v6 12/20] fs: add a new fstype flag to indicate how writeback errors are tracked Date: Thu, 15 Jun 2017 01:22:21 -0700 Message-ID: <20170615082221.GA22809@infradead.org> References: <20170612122316.13244-1-jlayton@redhat.com> <20170612122316.13244-15-jlayton@redhat.com> <20170612124513.GC18360@infradead.org> <1497349472.5762.1.camel@redhat.com> <20170614064731.GB3598@infradead.org> <1497461083.6752.7.camel@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Christoph Hellwig , Andrew Morton , Al Viro , Jan Kara , tytso@mit.edu, axboe@kernel.dk, mawilcox@microsoft.com, ross.zwisler@linux.intel.com, corbet@lwn.net, Chris Mason , Josef Bacik , David Sterba , "Darrick J . Wong" , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-block@vger.kernel.org To: Jeff Layton Return-path: Received: from bombadil.infradead.org ([65.50.211.133]:53621 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752008AbdFOIWn (ORCPT ); Thu, 15 Jun 2017 04:22:43 -0400 Content-Disposition: inline In-Reply-To: <1497461083.6752.7.camel@redhat.com> Sender: linux-ext4-owner@vger.kernel.org List-ID: On Wed, Jun 14, 2017 at 01:24:43PM -0400, Jeff Layton wrote: > In this smaller set, it's only really used for DAX. DAX only is implemented by three filesystems, please just fix them up in one go. > sync_file_range: ->fsync isn't called directly there, and I think we > probably want similar semantics to fsync() for it sync_file_range is only supposed to sync data, so it should not call ->fsync. > JBD2: will try to re-set the error after clearing it with > filemap_fdatawait. That's problematic with the new infrastructure so we > need some way to avoid it. JBD2 only has two users, please fix them up in one go.