From: Theodore Ts'o <tytso@mit.edu>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-ext4 <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] ext4: fix off-by-one fsmap error on 1k block filesystems
Date: Fri, 23 Jun 2017 01:01:31 -0400 [thread overview]
Message-ID: <20170623050131.2feyc7daq7adwtat@thunk.org> (raw)
In-Reply-To: <20170621182940.GB4728@birch.djwong.org>
On Wed, Jun 21, 2017 at 11:29:40AM -0700, Darrick J. Wong wrote:
> For 1k-block filesystems, the filesystem starts at block 1, not block 0.
> This fact is recorded in s_first_data_block, so use that to bump up the
> start_fsb before we start querying the filesystem for its space map.
> Without this, ext4/026 fails on 1k block ext4 because various functions
> (notably ext4_get_group_no_and_offset) don't know what to do with an
> fsblock that is "before" the start of the filesystem and return garbage
> results (blockgroup 2^32-1, etc.) that confuse fsmap.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Thanks, applied.
- Ted
prev parent reply other threads:[~2017-06-23 5:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-21 18:29 [PATCH] ext4: fix off-by-one fsmap error on 1k block filesystems Darrick J. Wong
2017-06-23 5:01 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170623050131.2feyc7daq7adwtat@thunk.org \
--to=tytso@mit.edu \
--cc=darrick.wong@oracle.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).