From: Theodore Ts'o <tytso@mit.edu>
To: Tahsin Erdogan <tahsin@google.com>
Cc: Andreas Dilger <adilger@dilger.ca>,
"Darrick J . Wong" <darrick.wong@oracle.com>,
Jan Kara <jack@suse.cz>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ext4: fix __ext4_xattr_set_credits()
Date: Tue, 4 Jul 2017 00:22:09 -0400 [thread overview]
Message-ID: <20170704042209.7ahxiwakxzg4qcqf@thunk.org> (raw)
In-Reply-To: <20170628214750.31548-1-tahsin@google.com>
On Wed, Jun 28, 2017 at 02:47:50PM -0700, Tahsin Erdogan wrote:
> __ext4_xattr_set_credits() calculates journal credits needed for a
> set xattr operation. Currently, credits needed for quota updates are
> added only if ea_inode feature is enabled which is wrong. Fix this by
> moving quota related additions to above ea_inode feature check.
>
> Fixes: 74c5bfa651af ("ext4: xattr inode deduplication")
>
> Signed-off-by: Tahsin Erdogan <tahsin@google.com>
Thanks, I've folded this into the xattr_inode_deduplication patch.
- Ted
prev parent reply other threads:[~2017-07-04 4:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-28 21:47 [PATCH] ext4: fix __ext4_xattr_set_credits() Tahsin Erdogan
2017-06-28 22:26 ` Andreas Dilger
2017-07-04 4:22 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170704042209.7ahxiwakxzg4qcqf@thunk.org \
--to=tytso@mit.edu \
--cc=adilger@dilger.ca \
--cc=darrick.wong@oracle.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tahsin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox