From: Theodore Ts'o <tytso@mit.edu>
To: Colin King <colin.king@canonical.com>
Cc: Andreas Dilger <adilger.kernel@dilger.ca>,
linux-ext4@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][ext4-next] ext4: ensure error return ret is zero on successful return
Date: Thu, 6 Jul 2017 15:28:15 -0400 [thread overview]
Message-ID: <20170706192815.pj4ptivvnuo2wrmy@thunk.org> (raw)
In-Reply-To: <20170623145840.26779-1-colin.king@canonical.com>
On Fri, Jun 23, 2017 at 03:58:40PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The error return ret is not set on a successful return path and
> so it returns a garbage value. Ensure it is is set to zero on
> a successful return.
>
> Detected by CoverityScan, CID#1446616 ("Uninitialized scalar variable")
>
> Fixes: 3499c0fb822d ("quota: add get_inode_usage callback to transfer multi-inode charges")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Thanks, I've folded this into the "quota: add get_inode_usage callback
to transfer multi-inode charges" with credit for your providing the
fix.
- Ted
prev parent reply other threads:[~2017-07-06 19:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-23 14:58 [PATCH][ext4-next] ext4: ensure error return ret is zero on successful return Colin King
2017-06-23 17:04 ` Tahsin Erdogan
2017-07-06 19:28 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170706192815.pj4ptivvnuo2wrmy@thunk.org \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox