From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Darrick J. Wong" <darrick.wong@oracle.com>
Subject: Re: [PATCH] generic: test negative SEEK_HOLE/SEEK_DATA offsets
Date: Thu, 13 Jul 2017 12:04:50 -0700
Message-ID: <20170713190450.GC4151@magnolia>
References: <20170712173923.GD4212@magnolia>
 <20170713081458.GE2478@eguan.usersys.redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: linux-fsdevel <linux-fsdevel@vger.kernel.org>,
        xfs <linux-xfs@vger.kernel.org>,
        linux-ext4 <linux-ext4@vger.kernel.org>,
        fstests <fstests@vger.kernel.org>
To: Eryu Guan <eguan@redhat.com>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <20170713081458.GE2478@eguan.usersys.redhat.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-Id: linux-ext4.vger.kernel.org

On Thu, Jul 13, 2017 at 04:14:58PM +0800, Eryu Guan wrote:
> On Wed, Jul 12, 2017 at 10:39:23AM -0700, Darrick J. Wong wrote:
> > Check that we get -ENXIO if the user calls SEEK_HOLE/SEEK_DATA with
> > a negative file offset.
> 
> A minor nit, this might be confusing, lseek returns -1 on error, and set
> errno to ENXIO, no one actually returns -ENXIO.
> 
> > 
> > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> > ---
> >  src/seek_sanity_test.c |   25 +++++++++++++++++
> >  tests/generic/702      |   70 ++++++++++++++++++++++++++++++++++++++++++++++++
> >  tests/generic/702.out  |    2 +
> >  tests/generic/group    |    1 +
> >  4 files changed, 98 insertions(+)
> >  create mode 100755 tests/generic/702
> >  create mode 100644 tests/generic/702.out
> > 
> > diff --git a/src/seek_sanity_test.c b/src/seek_sanity_test.c
> > index a58ec36..547f0a4 100644
> > --- a/src/seek_sanity_test.c
> > +++ b/src/seek_sanity_test.c
> > @@ -274,6 +274,30 @@ static int huge_file_test(int fd, int testnum, off_t filsz)
> >  	return ret;
> >  }
> >  
> > +/* Make sure we get ENXIO if we pass in a negative offset. */
> > +static int test18(int fd, int testnum)
> > +{
> > +	int ret = 0;
> > +	off_t pos;
> > +
> > +	errno = 0;
> > +	pos = lseek(fd, -1, SEEK_HOLE);
> > +	if (pos != -1 || errno != ENXIO) {
> > +		printf("%02d.1 SEEK_HOLE expected -1 with errno %d, got %jd and %d.\n",
> > +		       testnum, -ENXIO, pos, -errno);
> > +		ret++;
> > +	}
> > +
> > +	errno = 0;
> > +	pos = lseek(fd, -1, SEEK_DATA);
> > +	if (pos != -1 || errno != ENXIO) {
> > +		printf("%02d.1 SEEK_DATA expected -1 with errno %d, got %jd and %d.\n",
> > +		       testnum, -ENXIO, pos, -errno);
> > +		ret++;
> > +	}
> > +	return ret;
> 
> Seems cleaner to use do_lseek() helper, e.g.
> 
> static int test18(int fd, int testnum)
> {
> 	int ret = 0;
> 
> 	/* file size doesn't matter in this test, set to 0 */
> 	ret += do_lseek(testnum, 1, fd, 0, SEEK_HOLE, -1, -1);
> 	ret += do_lseek(testnum, 2, fd, 0, SEEK_DATA, -1, -1);
> 	
> 	return ret;
> }
> 
> And test reports "succ" or "FAIL" as what other subtests do
> 
> 18. Test file with negative SEEK_{HOLE,DATA} offsets  
> 18.01 SEEK_HOLE expected -1 or -1, got 0.                         FAIL
> 18.02 SEEK_DATA expected -1 with errno -6, got -1.                FAIL

Sure, will change and resend.

--D

> 
> Thanks,
> Eryu
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html