From: Theodore Ts'o <tytso@mit.edu>
To: Damien Guibouret <damien.guibouret@partition-saving.com>
Cc: Andreas Dilger <adilger@dilger.ca>,
linux-ext4@vger.kernel.org, eggert@cs.ucla.edu
Subject: Re: [PATCH] ext4: fix dir_nlink behaviour
Date: Sat, 22 Jul 2017 12:49:45 -0400 [thread overview]
Message-ID: <20170722164945.77z7bmk3rxbfceym@thunk.org> (raw)
In-Reply-To: <59735561.9020305@partition-saving.com>
On Sat, Jul 22, 2017 at 03:38:41PM +0200, Damien Guibouret wrote:
>
> If you look at vfs layer, vfs_mkdir does the check against max_links with >=
> and so if you reach the value, you will never be able to create a new
> directory even if nlink feature is present. Actually it is not a problem
> because ext4 does not set the s_max_links value in vfs (do not know why as
> ext2 set it perhaps because there is no limit if nlink is set?), but it
> could be some latent bug if someday somebody thinks it could be a good idea
> to set it.
We can't set s_max_links precisely because of the dir_nlinks feature.
So the fact that it is not set today is deliberate, and if someone
thought it was good idea, I and the other ext4 developers would NAK
it.
- Ted
next prev parent reply other threads:[~2017-07-22 16:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-21 22:49 [PATCH] ext4: fix dir_nlink behaviour Andreas Dilger
2017-07-22 13:38 ` Damien Guibouret
2017-07-22 16:49 ` Theodore Ts'o [this message]
2017-08-05 23:53 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170722164945.77z7bmk3rxbfceym@thunk.org \
--to=tytso@mit.edu \
--cc=adilger@dilger.ca \
--cc=damien.guibouret@partition-saving.com \
--cc=eggert@cs.ucla.edu \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox