From: Theodore Ts'o <tytso@mit.edu>
To: Tahsin Erdogan <tahsin@google.com>
Cc: Andreas Dilger <adilger@dilger.ca>,
"Darrick J . Wong" <darrick.wong@oracle.com>,
linux-ext4@vger.kernel.org
Subject: Re: [PATCH 3/4] libext2fs: eliminate empty element holes in ext2_xattr_handle->attrs
Date: Sun, 23 Jul 2017 22:53:51 -0400 [thread overview]
Message-ID: <20170724025351.seejfxujn2wzplzo@thunk.org> (raw)
In-Reply-To: <20170707121246.6159-3-tahsin@google.com>
On Fri, Jul 07, 2017 at 05:12:45AM -0700, Tahsin Erdogan wrote:
> When an extended attribute is removed, its array element is emptied.
> This creates holes in the array so various places that want to walk
> filled elements have to do an empty element check.
>
> Have remove operation shift remaining filled elements to the left.
> This allows a simple iteration up to ext2_xattr_handle->count to walk
> all filled entries, and so empty element checks become unnecessary.
>
> Signed-off-by: Tahsin Erdogan <tahsin@google.com>
Thanks, applied.
- Ted
next prev parent reply other threads:[~2017-07-24 2:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-07 12:12 [PATCH 1/4] e2fsck: update quota inode accounting for ea_inode feature Tahsin Erdogan
2017-07-07 12:12 ` [PATCH 2/4] libext2fs: rename ext2_xattr_handle->length to capacity Tahsin Erdogan
2017-07-24 2:46 ` Theodore Ts'o
2017-07-07 12:12 ` [PATCH 3/4] libext2fs: eliminate empty element holes in ext2_xattr_handle->attrs Tahsin Erdogan
2017-07-24 2:53 ` Theodore Ts'o [this message]
2017-07-07 12:12 ` [PATCH 4/4] libext2fs: add ea_inode support to set xattr Tahsin Erdogan
2017-07-24 3:30 ` Theodore Ts'o
2017-07-24 1:25 ` [PATCH 1/4] e2fsck: update quota inode accounting for ea_inode feature Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170724025351.seejfxujn2wzplzo@thunk.org \
--to=tytso@mit.edu \
--cc=adilger@dilger.ca \
--cc=darrick.wong@oracle.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tahsin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).