From: Theodore Ts'o <tytso@mit.edu>
To: Miao Xie <miaoxie@huawei.com>
Cc: linux-ext4@vger.kernel.org, lixi@ddn.com, yi.zhang@huawei.com,
adilger@dilger.ca, wshilong@ddn.com, sihara@ddn.com
Subject: Re: [PATCH 2/4] ext4: restructure ext4_expand_extra_isize
Date: Sun, 6 Aug 2017 00:47:59 -0400 [thread overview]
Message-ID: <20170806044759.h2jm3nhxv6gqemuy@thunk.org> (raw)
In-Reply-To: <1499360993-17130-2-git-send-email-miaoxie@huawei.com>
On Fri, Jul 07, 2017 at 01:09:51AM +0800, Miao Xie wrote:
> Current ext4_expand_extra_isize just tries to expand extra isize, if
> someone is holding xattr lock or some check fails, it will give up.
> So rename its name to ext4_try_to_expand_extra_isize.
>
> Besides that, we clean up unnecessary check and move some relative checks
> into it.
>
> Signed-off-by: Miao Xie <miaoxie@huawei.com>
> Reviewed-by: Wang Shilong <wshilong@ddn.com>
Thanks, applied.
- Ted
next prev parent reply other threads:[~2017-08-06 4:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-06 17:09 [PATCH 1/4] ext4: fix forgetten xattr lock protection in ext4_expand_extra_isize Miao Xie
2017-07-06 17:09 ` [PATCH 2/4] ext4: restructure ext4_expand_extra_isize Miao Xie
2017-08-06 4:47 ` Theodore Ts'o [this message]
2017-07-06 17:09 ` [PATCH 3/4] ext4: cleanup ext4_expand_extra_isize_ea() Miao Xie
2017-08-06 4:56 ` Theodore Ts'o
2017-07-06 17:09 ` [PATCH 4/4] ext4, project: expand inode extra size if possible Miao Xie
2017-08-06 5:05 ` Theodore Ts'o
2017-07-13 12:55 ` [PATCH 1/4] ext4: fix forgetten xattr lock protection in ext4_expand_extra_isize Miao Xie
2017-07-13 13:04 ` Wang Shilong
2017-07-13 16:47 ` Theodore Ts'o
2017-08-06 4:28 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170806044759.h2jm3nhxv6gqemuy@thunk.org \
--to=tytso@mit.edu \
--cc=adilger@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=lixi@ddn.com \
--cc=miaoxie@huawei.com \
--cc=sihara@ddn.com \
--cc=wshilong@ddn.com \
--cc=yi.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox