From: Eric Whitney <enwlinux@gmail.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Eric Whitney <enwlinux@gmail.com>,
sandeen@redhat.com, linux-ext4@vger.kernel.org
Subject: Re: Release of e2fsprogs 1.43.5
Date: Fri, 11 Aug 2017 17:23:10 -0400 [thread overview]
Message-ID: <20170811212310.GA19995@localhost.localdomain> (raw)
In-Reply-To: <20170810173713.GA4458@magnolia>
* Darrick J. Wong <darrick.wong@oracle.com>:
> On Thu, Aug 10, 2017 at 01:30:44PM -0400, Eric Whitney wrote:
> > * Eric Sandeen <esandeen@redhat.com>:
> > > On 8/5/17 9:34 AM, Theodore Ts'o wrote:
> > > > I've released e2fsprogs 1.43.5 in all of the usual places; it's tagged
> > > > in the git trees on git.kernel.org, github, and sourceforge, and
> > > > available for download at:
> > > >
> > > > ftp://ftp.kernel.org/pub/linux/kernel/people/tytso/e2fsprogs/v1.43.5
> > > >
> > > > and
> > > >
> > > > http://prdownloads.sourceforge.net/e2fsprogs/e2fsprogs-1.43.5.tar.gz
> > > >
> > > > The release notes for 1.43.5 can be found below.
> > >
> > > I'm getting test failures in rawhide with this, FWIW; on i686
> > > and arm:
> > >
> > > 336 tests succeeded 3 tests failed
> > > Tests failed: f_del_dup_quota f_quota f_quota_extent_opt
> > >
> > > Haven't dug into this yet (failures are on ephemeral build root
> > > on a build host), but has anyone else seen problems?
> > >
> >
> > Yes - I can reproduce these failures on Debian Jessie on 32 bit x86, as can
> > Ted.
> >
> > Reverting "libext2fs: fix compile errors/warnings" (a850bc56e0aa) resolves
> > the problem for me. In particular, undoing the format string changes in
> > scan_dquots_callback() fixes the failures. I think we need to use %lld as
> > dqb_curspace and dqb_curinodes are __le64,
>
> lib/support/quotaio.h does:
>
> typedef int64_t qsize_t;
>
> struct util_dqblk {
> ...
> qsize_t dqb_curinodes;
> ...
> qsize_t dqb_curspace;
> ...
> };
>
> and if they're int64_t then you could use PRId64.
>
> --D
My mistake - I grepped the wrong declarations of dqb_curinodes/dqb_curspace to
determine type. They're indeed int64_t in this case.
Eric
next prev parent reply other threads:[~2017-08-11 21:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-05 16:34 Release of e2fsprogs 1.43.5 Theodore Ts'o
2017-08-09 23:58 ` Eric Sandeen
2017-08-10 17:30 ` Eric Whitney
2017-08-10 17:37 ` Darrick J. Wong
2017-08-11 21:23 ` Eric Whitney [this message]
2017-08-13 19:20 ` [PATCH] libsupport: fix 32-bit quota test failures Theodore Ts'o
2017-08-10 18:05 ` Release of e2fsprogs 1.43.5 Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170811212310.GA19995@localhost.localdomain \
--to=enwlinux@gmail.com \
--cc=darrick.wong@oracle.com \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).