From: Dan Carpenter <dan.carpenter@oracle.com>
To: sandeen@redhat.com
Cc: SF Markus Elfring <elfring@users.sourceforge.net>,
linux-ext4@vger.kernel.org,
Andreas Dilger <adilger.kernel@dilger.ca>,
"Theodore Ts'o" <tytso@mit.edu>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/2] ext4: Delete an error message for a failed memory allocation in ext4_multi_mount_protect()
Date: Thu, 24 Aug 2017 22:16:45 +0300 [thread overview]
Message-ID: <20170824191645.ha3bw5n24lqcpxd7@mwanda> (raw)
In-Reply-To: <b21f6c3d-2cad-3f72-f410-f608ea5f4cea@redhat.com>
On Sat, Aug 19, 2017 at 12:08:29PM -0500, Eric Sandeen wrote:
> On 8/19/17 6:47 AM, SF Markus Elfring wrote:
> > From: Markus Elfring <elfring@users.sourceforge.net>
> > Date: Sat, 19 Aug 2017 13:04:50 +0200
> >
> > Omit an extra message for a memory allocation failure in this function.
>
> I might be dense, but what makes this message "extra?"
>
> (I suppose kmalloc squawks too if it fails, but is Coccinelle
> now warning about explicit memory allocation failure warnings?)
>
Yeah... Checkpatch complains that the kmalloc squawks is enough.
"WARNING: Possible unnecessary 'out of memory' message". This
allocation is small so it's guaranteed to succeed in current kernels.
regards,
dan carpenter
next prev parent reply other threads:[~2017-08-24 19:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-19 11:46 [PATCH 0/2] fs-ext4: Adjustments for two function implementations SF Markus Elfring
2017-08-19 11:47 ` [PATCH 1/2] ext4: Delete an error message for a failed memory allocation in ext4_multi_mount_protect() SF Markus Elfring
2017-08-19 17:08 ` Eric Sandeen
2017-08-19 18:00 ` SF Markus Elfring
2017-08-24 17:44 ` Theodore Ts'o
2017-08-24 19:16 ` Dan Carpenter [this message]
2017-08-19 11:48 ` [PATCH 2/2] ext4: Improve a size determination in two functions SF Markus Elfring
2017-08-20 1:49 ` Eric Sandeen
2017-08-24 17:50 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170824191645.ha3bw5n24lqcpxd7@mwanda \
--to=dan.carpenter@oracle.com \
--cc=adilger.kernel@dilger.ca \
--cc=elfring@users.sourceforge.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox