linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Markus Trippelsdorf <markus@trippelsdorf.de>
To: Theodore Ts'o <tytso@mit.edu>
Cc: Andreas Dilger <adilger.kernel@dilger.ca>, linux-ext4@vger.kernel.org
Subject: mounting with lazytime doesn't work on ext4
Date: Mon, 18 Sep 2017 21:26:44 +0200	[thread overview]
Message-ID: <20170918192644.GA232@x4> (raw)

I switched back to ext4 yesterday, because my btrfs fs got corrupted.
However mounting with lazytime doesn't work, neither specifying it in
/etc/fstab nor a manual remount. It looks like the option is simply
ignored.

Strace shows, e.g.:

 # mount -o lazytime /boot
mount("/dev/sdc2", "/boot", "ext4", MS_LAZYTIME, NULL) = 0 
EXT4-fs (sdc2): mounted filesystem with ordered data mode. Opts: (null) 
/dev/sdc2 on /boot type ext4 (rw,relatime,data=ordered)

 # mount -o remount,lazytime /var
mount("/dev/sdb2", "/var", 0x12c4460, MS_REMOUNT|MS_NOATIME|MS_LAZYTIME, NULL) = 0 
EXT4-fs (sdb2): re-mounted. Opts: (null)
/dev/sdb2 on /var type ext4 (rw,noatime,data=ordered)

When I set "sb->s_flags |= MS_LAZYTIME;" unconditionally in
fs/ext4/super.c:5057 (just deleting the if statement), then lazytime
gets used when I remount.

I'm running the latest git tree (4.14.0-rc1).

-- 
Markus

             reply	other threads:[~2017-09-18 19:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-18 19:26 Markus Trippelsdorf [this message]
2017-09-19  8:35 ` mounting with lazytime doesn't work on ext4 Markus Trippelsdorf
2017-09-19 10:18   ` [PATCH] VFS: Handle lazytime in do_mount() Markus Trippelsdorf
2017-09-19 10:37     ` [PATCH v2] " Markus Trippelsdorf
2017-09-19 15:25       ` Lukas Czerner
2017-09-30  7:10         ` Markus Trippelsdorf
2017-09-19 14:46   ` mounting with lazytime doesn't work on ext4 Lukas Czerner
2017-09-19 14:55     ` Markus Trippelsdorf
2017-09-19 11:00 ` Lukas Czerner
2017-09-19 11:03   ` Markus Trippelsdorf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170918192644.GA232@x4 \
    --to=markus@trippelsdorf.de \
    --cc=adilger.kernel@dilger.ca \
    --cc=linux-ext4@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).