From: Theodore Ts'o <tytso@mit.edu>
To: Nikolay Borisov <nborisov@suse.com>
Cc: Zheng Lv <lv.zheng.2015@gmail.com>, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: Use symbolic constants for well-known pow 2 sizes
Date: Tue, 3 Oct 2017 12:17:14 -0400 [thread overview]
Message-ID: <20171003161714.w6axjxymb45mwno5@thunk.org> (raw)
In-Reply-To: <26a209c0-384f-9646-9700-adb48c83eac3@suse.com>
On Tue, Oct 03, 2017 at 12:31:45PM +0300, Nikolay Borisov wrote:
>
>
> On 3.10.2017 10:00, Zheng Lv wrote:
> >> No functional changes, just makes the code a bit more readable. Also fix 1
> >> trailing whitespace
> >
> > I don't think so.
> >
> > AFAIK, SZ_16 is just 16, not (16 * 1024). XXX * 1024 should be replaced with
> > SZ_XXXk rather than SZ_XXX.
>
> True, I meant kilobytes and not bytes, so my bad. THe patch is buggy
> will redo it and resend. Thanks for spotting it.
The symbolic constants don't also seem to add much in terms of
readability, at least to my view....
- Ted
prev parent reply other threads:[~2017-10-03 16:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-29 13:58 [PATCH] ext4: Use symbolic constants for well-known pow 2 sizes Nikolay Borisov
2017-10-03 7:00 ` Zheng Lv
2017-10-03 9:31 ` Nikolay Borisov
2017-10-03 16:17 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171003161714.w6axjxymb45mwno5@thunk.org \
--to=tytso@mit.edu \
--cc=linux-ext4@vger.kernel.org \
--cc=lv.zheng.2015@gmail.com \
--cc=nborisov@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox