* [PATCH] ext4: skip project quota tests if the kernel does not support them
@ 2017-10-08 19:27 Theodore Ts'o
2017-10-08 21:42 ` Dave Chinner
0 siblings, 1 reply; 2+ messages in thread
From: Theodore Ts'o @ 2017-10-08 19:27 UTC (permalink / raw)
To: fstests; +Cc: Ext4 Developers List, Theodore Ts'o
In _scratch_enable_pquota, use _notrun if the file system with project
quotas enable can't be mounted, since that indicates the kernel
doesn't support that feature.
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
---
common/quota | 3 +++
1 file changed, 3 insertions(+)
diff --git a/common/quota b/common/quota
index f49728c2..d027a8c1 100644
--- a/common/quota
+++ b/common/quota
@@ -119,6 +119,9 @@ _scratch_enable_pquota()
[ "$FSTYP" != "ext4" ] && return
tune2fs -O quota,project $SCRATCH_DEV >>$seqres.full 2>&1
+ _scratch_mount >/dev/null 2>&1 \
+ || _notrun "kernel doesn't support project feature on $FSTYP"
+ _scratch_unmount
}
#
--
2.11.0.rc0.7.gbe5a750
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ext4: skip project quota tests if the kernel does not support them
2017-10-08 19:27 [PATCH] ext4: skip project quota tests if the kernel does not support them Theodore Ts'o
@ 2017-10-08 21:42 ` Dave Chinner
0 siblings, 0 replies; 2+ messages in thread
From: Dave Chinner @ 2017-10-08 21:42 UTC (permalink / raw)
To: Theodore Ts'o; +Cc: fstests, Ext4 Developers List
On Sun, Oct 08, 2017 at 03:27:46PM -0400, Theodore Ts'o wrote:
> In _scratch_enable_pquota, use _notrun if the file system with project
> quotas enable can't be mounted, since that indicates the kernel
> doesn't support that feature.
>
> Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Looks fine.
Acked-by: Dave Chinner <dchinner@redhat.com>
-Dave
--
Dave Chinner
david@fromorbit.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-08 21:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-08 19:27 [PATCH] ext4: skip project quota tests if the kernel does not support them Theodore Ts'o
2017-10-08 21:42 ` Dave Chinner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).