From: Team Athena <teamathena.nitc@gmail.com>
To: tytso@mit.edu, adilger.kernel@dilger.ca,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] ext4: Log inode exhaustion to dmesg
Date: Mon, 23 Oct 2017 17:32:47 +0530 [thread overview]
Message-ID: <20171023120247.lsupeazdwwpaisek@gaztest-VM> (raw)
Make a log in dmesg when file creation fails due to no free inodes.
The error code for both "out of disk space" and "out of inode" is the same.
This is misleading to the user. Logging the exact reason helps to find and
correct the issue from the users' side.
Fix bug 197335 - https://bugzilla.kernel.org/show_bug.cgi?id=197335
Signed-off-by: Team Athena <teamathena.nitc@gmail.com>
---
fs/ext4/namei.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
index c1cf020d..c3990d2d 100644
--- a/fs/ext4/namei.c
+++ b/fs/ext4/namei.c
@@ -2463,6 +2463,8 @@ static int ext4_create(struct inode *dir, struct dentry *dentry, umode_t mode,
ext4_journal_stop(handle);
if (err == -ENOSPC && ext4_should_retry_alloc(dir->i_sb, &retries))
goto retry;
+ else if (err == -ENOSPC && printk_ratelimited())
+ printk(pr_warning "ext4: No space on disk, inode usage full");
return err;
}
--
2.11.0
next reply other threads:[~2017-10-23 12:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-23 12:02 Team Athena [this message]
2017-10-23 12:04 ` [PATCH] ext4: Log inode exhaustion to dmesg Theodore Ts'o
2017-10-23 14:54 ` kbuild test robot
2017-10-23 15:21 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171023120247.lsupeazdwwpaisek@gaztest-VM \
--to=teamathena.nitc@gmail.com \
--cc=adilger.kernel@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox