From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gazala Muhamed Subject: [PATCH v2] Make a log in dmesg when file creation fails due to no free inodes Date: Wed, 25 Oct 2017 13:24:14 +0530 Message-ID: <20171025075414.mnizap2yjcmgkpn7@gaztest-VM> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii To: tytso@mit.edu, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, teamathena.nitc@gmail.com Return-path: Received: from mail-pg0-f65.google.com ([74.125.83.65]:51613 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751162AbdJYGYW (ORCPT ); Wed, 25 Oct 2017 02:24:22 -0400 Content-Disposition: inline Sender: linux-ext4-owner@vger.kernel.org List-ID: The error code for both "out of disk space" and "out of inodes" is the same This is misleading to the user. Logging the exact reason helps to find and debug the issue from the user's side. Fix bug 197335 - https://bugzilla.kernel.org/show_bug.cgi?id=197335 Signed-off-by: Gazala Muhamed --- Changes in v2: - Use ext4_warning instead of a bare printk - Signed-off with real name --- fs/ext4/namei.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c index c1cf020d..4b18badd 100644 --- a/fs/ext4/namei.c +++ b/fs/ext4/namei.c @@ -2463,6 +2463,8 @@ static int ext4_create(struct inode *dir, struct dentry *dentry, umode_t mode, ext4_journal_stop(handle); if (err == -ENOSPC && ext4_should_retry_alloc(dir->i_sb, &retries)) goto retry; + else if (err == -ENOSPC) + ext4_warning(dir->i_sb, "No space on disk, out of inodes"); return err; } -- 2.11.0