From: Theodore Ts'o <tytso@mit.edu>
To: Andreas Dilger <adilger@dilger.ca>
Cc: Andi Kleen <andi@firstfloor.org>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH] ext4: Support fast symlinks from ext3 file systems
Date: Sun, 3 Dec 2017 22:49:37 -0500 [thread overview]
Message-ID: <20171204034937.taemzvmslauyfous@thunk.org> (raw)
In-Reply-To: <24E86306-4A6C-48AE-9999-A9D935A2DC12@dilger.ca>
On Mon, Nov 27, 2017 at 11:08:53AM -0700, Andreas Dilger wrote:
> On Nov 27, 2017, at 10:37 AM, Andi Kleen <andi@firstfloor.org> wrote:
> >
> > From: Andi Kleen <ak@linux.intel.com>
> >
> > dbb3c27f5b91c4 (ext4: change fast symlink test to not rely on i_blocks)
> > broke ~10 years old ext3 file systems created by 2.6.17. Any ELF
> > executable fails because the /lib/ld-linux.so.2 fast symlink
> > cannot be read anymore.
> >
> > The patch assumed fast symlinks were created in a specific way,
> > but that's not true on these really old file systems.
> >
> > The new behavior is apparently needed only with the large EA inode
> > feature.
> >
> > Revert to the old behavior if the large EA inode feature is not set.
> >
> > This makes my old VM boot again.
> >
> > Fixes: dbb3c27f5b91c4 (ext4: change fast symlink test to not rely ...)
> > Signed-off-by: Andi Kleen <ak@linux.intel.com>
>
> Reviewed-by: Andreas Dilger <adilger@dilger.ca>
Thanks, applied.
- Ted
prev parent reply other threads:[~2017-12-04 3:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-27 17:37 [PATCH] ext4: Support fast symlinks from ext3 file systems Andi Kleen
2017-11-27 18:08 ` Andreas Dilger
2017-12-04 3:49 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171204034937.taemzvmslauyfous@thunk.org \
--to=tytso@mit.edu \
--cc=adilger@dilger.ca \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox