From: Christoph Hellwig <hch@infradead.org>
To: Theodore Ts'o <tytso@mit.edu>,
Seongbae Son <seongbae.son@gmail.com>,
linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ext4: delayed inode update for the consistency of file size after a crash
Date: Mon, 18 Dec 2017 04:32:02 -0800 [thread overview]
Message-ID: <20171218123202.GA25645@infradead.org> (raw)
In-Reply-To: <20171216233239.oy4mcyjuq6hjugnx@thunk.org>
> that update of the timestamp and i_size needs to be moved to an I/O
> completion handler. We do this already to convert unwritten requests
> to be written in fs/ext4/page_io.c. See ext4_put_io_end_defer() in
> fs/ext4/page_io.c; if we need to convert unwritten extents the
> EXT4_IO_END_UNWRITTEN flag is set, and ext4_add_complete_io() tacks
> the io_end queue onto a workqueue. This infrastructure could be made
> more general so that it can do other work after the I/O has been
> completed, including the i_size update.
That's what we do for the i_size update in XFS.
next prev parent reply other threads:[~2017-12-18 12:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-16 4:33 [PATCH] ext4: delayed inode update for the consistency of file size after a crash Seongbae Son
2017-12-16 23:32 ` Theodore Ts'o
2017-12-18 12:32 ` Christoph Hellwig [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-12-10 12:12 seongbaeSon
2017-12-10 17:16 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171218123202.GA25645@infradead.org \
--to=hch@infradead.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=seongbae.son@gmail.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).