From: Theodore Ts'o <tytso@mit.edu>
To: Andreas Dilger <adilger@dilger.ca>
Cc: linux-ext4 <linux-ext4@vger.kernel.org>,
Shuichi Ihara <sihara@ddn.com>, Li Xi <lixi@ddn.com>,
Wang Shilong <wshilong@ddn.com>
Subject: Re: [PATCH] misc: add e2mmpstatus utility
Date: Fri, 29 Dec 2017 20:57:04 -0500 [thread overview]
Message-ID: <20171230015704.GE11757@thunk.org> (raw)
In-Reply-To: <F976B3B9-90C4-446E-B8D4-49571CA535A4@dilger.ca>
On Fri, Dec 29, 2017 at 04:02:04PM -0700, Andreas Dilger wrote:
> > Why not include this into dumpe2fs? Maybe dumpe2fs -m to just print
> > the MMP information and include the MMP nodetime and time for either
> > the full dumpe2fs or dumpe2fs -h output?
>
> That would definitely be an option. The mmpstatus utility was written by
> DDN, and I'm passing it on after some code cleanup.
>
> I think it would be reasonable to include the other MMP fields into the
> dumpe2fs output, and then run the full MMP activity check if called with
> "-m" or named as "mmpstatus". I don't want dumpe2fs to be blocked on
> the MMP update checking all the time, since that can be slow.
SGTM.
> I'll see if I can get a patch out in the next couple of days.
Many thanks!!
Cheers,
- Ted
prev parent reply other threads:[~2017-12-30 1:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-22 9:22 [PATCH] misc: add e2mmpstatus utility Andreas Dilger
2017-12-22 17:17 ` Theodore Ts'o
2017-12-29 23:02 ` Andreas Dilger
2017-12-30 1:57 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171230015704.GE11757@thunk.org \
--to=tytso@mit.edu \
--cc=adilger@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=lixi@ddn.com \
--cc=sihara@ddn.com \
--cc=wshilong@ddn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).