From: Theodore Ts'o <tytso@mit.edu>
To: Eric Biggers <ebiggers3@gmail.com>
Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Eric Biggers <ebiggers@google.com>, Jan Kara <jack@suse.cz>,
Jiang Biao <jiang.biao2@zte.com.cn>
Subject: Re: [PATCH] Revert "fs/mbcache.c: make count_objects() more robust"
Date: Sun, 7 Jan 2018 16:36:09 -0500 [thread overview]
Message-ID: <20180107213609.GD17380@thunk.org> (raw)
In-Reply-To: <20180106180654.7373-1-ebiggers3@gmail.com>
On Sat, Jan 06, 2018 at 10:06:54AM -0800, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> This reverts commit d5dabd633922ac5ee5bcc67748f7defb8b211469.
>
> This patch did absolutely nothing, because ->c_entry_count is unsigned.
>
> In addition if there is a bug in how mbcache maintains its entry count,
> it needs to be fixed, not just hacked around. (There is no obvious bug,
> though.)
Thanks, applied.
- Ted
prev parent reply other threads:[~2018-01-07 21:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-06 18:06 [PATCH] Revert "fs/mbcache.c: make count_objects() more robust" Eric Biggers
2018-01-07 21:04 ` Theodore Ts'o
2018-01-07 21:36 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180107213609.GD17380@thunk.org \
--to=tytso@mit.edu \
--cc=akpm@linux-foundation.org \
--cc=ebiggers3@gmail.com \
--cc=ebiggers@google.com \
--cc=jack@suse.cz \
--cc=jiang.biao2@zte.com.cn \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).