From: Theodore Ts'o <tytso@mit.edu>
To: Petros Koutoupis <petros@petroskoutoupis.com>
Cc: adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4.h: Fixed alignment and minor code cleanup.
Date: Sun, 7 Jan 2018 23:57:29 -0500 [thread overview]
Message-ID: <20180108045729.GG17380@thunk.org> (raw)
In-Reply-To: <1513800558.15997.3.camel@petroskoutoupis.com>
On Wed, Dec 20, 2017 at 02:09:18PM -0600, Petros Koutoupis wrote:
> Minor code cleanup: Fixed alignment and a reduction of lines in header file.
>
> Signed-off-by: Petros Koutoupis <petros@petroskoutoupis.com>
The patch is whitespace damaged, unfortunately.
Also, the cleanup actually isn't the best cleanup. We should really
be changing ext4_chksum() to take a struct super instead of a struct
ext4_sb_info, so we can call ext4_std_error() so we can properly log
an error without immediately crashing the kernel. The chksum
shouldn't really ever fail, but if it does, calling ext4_error() is
better than bringing down the whole system with a BUG_ON.
Cheers,
- Ted
prev parent reply other threads:[~2018-01-08 4:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-20 20:09 [PATCH] ext4.h: Fixed alignment and minor code cleanup Petros Koutoupis
2018-01-08 4:57 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180108045729.GG17380@thunk.org \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=petros@petroskoutoupis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).