* [PATCH] common/rc: ext4 doesn't support O_DIRECT with data journaling
@ 2018-01-10 21:19 Eric Whitney
2018-01-11 18:21 ` Theodore Ts'o
0 siblings, 1 reply; 2+ messages in thread
From: Eric Whitney @ 2018-01-10 21:19 UTC (permalink / raw)
To: fstests; +Cc: linux-ext4
Modify _require_odirect() to skip O_DIRECT tests if the ext4 mount
option data=journal has been applied. Because ext4 disables its
O_DIRECT support when in data journaling mode, no significant value is
obtained by running these tests and they consume a significant amount
of run time. Additionally, this change eliminates the need to triage
false negative O_DIRECT test results caused by test problems, as has
occurred from time to time.
Signed-off-by: Eric Whitney <enwlinux@gmail.com>
---
common/rc | 2 ++
1 file changed, 2 insertions(+)
diff --git a/common/rc b/common/rc
index 9216efdb..86cc9665 100644
--- a/common/rc
+++ b/common/rc
@@ -2150,6 +2150,8 @@ _require_odirect()
if [ $FSTYP = "ext4" ] ; then
if echo "$MOUNT_OPTIONS" | grep -q "test_dummy_encryption"; then
_notrun "ext4 encryption doesn't support O_DIRECT"
+ elif echo "$MOUNT_OPTIONS" | grep -q "data=journal"; then
+ _notrun "ext4 data journaling doesn't support O_DIRECT"
fi
fi
testfile=$TEST_DIR/$$.direct
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] common/rc: ext4 doesn't support O_DIRECT with data journaling
2018-01-10 21:19 [PATCH] common/rc: ext4 doesn't support O_DIRECT with data journaling Eric Whitney
@ 2018-01-11 18:21 ` Theodore Ts'o
0 siblings, 0 replies; 2+ messages in thread
From: Theodore Ts'o @ 2018-01-11 18:21 UTC (permalink / raw)
To: Eric Whitney; +Cc: fstests, linux-ext4
On Wed, Jan 10, 2018 at 04:19:05PM -0500, Eric Whitney wrote:
> Modify _require_odirect() to skip O_DIRECT tests if the ext4 mount
> option data=journal has been applied. Because ext4 disables its
> O_DIRECT support when in data journaling mode, no significant value is
> obtained by running these tests and they consume a significant amount
> of run time. Additionally, this change eliminates the need to triage
> false negative O_DIRECT test results caused by test problems, as has
> occurred from time to time.
>
> Signed-off-by: Eric Whitney <enwlinux@gmail.com>
Reviewed-by: Theodore Ts'o <tytso@mit.edu>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-01-11 18:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-10 21:19 [PATCH] common/rc: ext4 doesn't support O_DIRECT with data journaling Eric Whitney
2018-01-11 18:21 ` Theodore Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).