From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Tyson Nottingham <tgnottingham@gmail.com>
Cc: linux-ext4@vger.kernel.org, tytso@mit.edu
Subject: Re: [PATCH] debugfs: remove misplaced "MMP is unsupported" message.
Date: Tue, 23 Jan 2018 21:04:24 -0800 [thread overview]
Message-ID: <20180124050424.GD5594@magnolia> (raw)
In-Reply-To: <1516764797-27781-1-git-send-email-tgnottingham@gmail.com>
On Tue, Jan 23, 2018 at 07:33:17PM -0800, Tyson Nottingham wrote:
> This message was inadvertently copied from the version of do_dump_mmp
> that is used when CONFIG_MMP is disabled.
>
> Signed-off-by: Tyson Nottingham <tgnottingham@gmail.com>
Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
> debugfs/debugfs.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/debugfs/debugfs.c b/debugfs/debugfs.c
> index 91ededf..e46532f 100644
> --- a/debugfs/debugfs.c
> +++ b/debugfs/debugfs.c
> @@ -2366,8 +2366,6 @@ void do_dump_mmp(int argc EXT2FS_ATTR((unused)), char *argv[])
> fprintf(stdout, "device_name: %s\n", mmp_s->mmp_bdevname);
> fprintf(stdout, "magic: 0x%x\n", mmp_s->mmp_magic);
> fprintf(stdout, "checksum: 0x%08x\n", mmp_s->mmp_checksum);
> - fprintf(stdout, "MMP is unsupported, please recompile with "
> - "--enable-mmp\n");
> }
> #else
> void do_dump_mmp(int argc EXT2FS_ATTR((unused)),
> --
> 2.7.4
>
next prev parent reply other threads:[~2018-01-24 5:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-24 3:33 [PATCH] debugfs: remove misplaced "MMP is unsupported" message Tyson Nottingham
2018-01-24 5:04 ` Darrick J. Wong [this message]
2018-02-08 4:28 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180124050424.GD5594@magnolia \
--to=darrick.wong@oracle.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tgnottingham@gmail.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).