linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] debugfs: remove misplaced "MMP is unsupported" message.
@ 2018-01-24  3:33 Tyson Nottingham
  2018-01-24  5:04 ` Darrick J. Wong
  2018-02-08  4:28 ` Theodore Ts'o
  0 siblings, 2 replies; 3+ messages in thread
From: Tyson Nottingham @ 2018-01-24  3:33 UTC (permalink / raw)
  To: linux-ext4; +Cc: tytso, Tyson Nottingham

This message was inadvertently copied from the version of do_dump_mmp
that is used when CONFIG_MMP is disabled.

Signed-off-by: Tyson Nottingham <tgnottingham@gmail.com>
---
 debugfs/debugfs.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/debugfs/debugfs.c b/debugfs/debugfs.c
index 91ededf..e46532f 100644
--- a/debugfs/debugfs.c
+++ b/debugfs/debugfs.c
@@ -2366,8 +2366,6 @@ void do_dump_mmp(int argc EXT2FS_ATTR((unused)), char *argv[])
 	fprintf(stdout, "device_name: %s\n", mmp_s->mmp_bdevname);
 	fprintf(stdout, "magic: 0x%x\n", mmp_s->mmp_magic);
 	fprintf(stdout, "checksum: 0x%08x\n", mmp_s->mmp_checksum);
-	fprintf(stdout, "MMP is unsupported, please recompile with "
-	                "--enable-mmp\n");
 }
 #else
 void do_dump_mmp(int argc EXT2FS_ATTR((unused)),
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] debugfs: remove misplaced "MMP is unsupported" message.
  2018-01-24  3:33 [PATCH] debugfs: remove misplaced "MMP is unsupported" message Tyson Nottingham
@ 2018-01-24  5:04 ` Darrick J. Wong
  2018-02-08  4:28 ` Theodore Ts'o
  1 sibling, 0 replies; 3+ messages in thread
From: Darrick J. Wong @ 2018-01-24  5:04 UTC (permalink / raw)
  To: Tyson Nottingham; +Cc: linux-ext4, tytso

On Tue, Jan 23, 2018 at 07:33:17PM -0800, Tyson Nottingham wrote:
> This message was inadvertently copied from the version of do_dump_mmp
> that is used when CONFIG_MMP is disabled.
> 
> Signed-off-by: Tyson Nottingham <tgnottingham@gmail.com>

Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>

> ---
>  debugfs/debugfs.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/debugfs/debugfs.c b/debugfs/debugfs.c
> index 91ededf..e46532f 100644
> --- a/debugfs/debugfs.c
> +++ b/debugfs/debugfs.c
> @@ -2366,8 +2366,6 @@ void do_dump_mmp(int argc EXT2FS_ATTR((unused)), char *argv[])
>  	fprintf(stdout, "device_name: %s\n", mmp_s->mmp_bdevname);
>  	fprintf(stdout, "magic: 0x%x\n", mmp_s->mmp_magic);
>  	fprintf(stdout, "checksum: 0x%08x\n", mmp_s->mmp_checksum);
> -	fprintf(stdout, "MMP is unsupported, please recompile with "
> -	                "--enable-mmp\n");
>  }
>  #else
>  void do_dump_mmp(int argc EXT2FS_ATTR((unused)),
> -- 
> 2.7.4
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] debugfs: remove misplaced "MMP is unsupported" message.
  2018-01-24  3:33 [PATCH] debugfs: remove misplaced "MMP is unsupported" message Tyson Nottingham
  2018-01-24  5:04 ` Darrick J. Wong
@ 2018-02-08  4:28 ` Theodore Ts'o
  1 sibling, 0 replies; 3+ messages in thread
From: Theodore Ts'o @ 2018-02-08  4:28 UTC (permalink / raw)
  To: Tyson Nottingham; +Cc: linux-ext4

On Tue, Jan 23, 2018 at 07:33:17PM -0800, Tyson Nottingham wrote:
> This message was inadvertently copied from the version of do_dump_mmp
> that is used when CONFIG_MMP is disabled.
> 
> Signed-off-by: Tyson Nottingham <tgnottingham@gmail.com>

Thanks, applied.

					- Ted

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-02-08  4:28 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-24  3:33 [PATCH] debugfs: remove misplaced "MMP is unsupported" message Tyson Nottingham
2018-01-24  5:04 ` Darrick J. Wong
2018-02-08  4:28 ` Theodore Ts'o

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).