From: Christoph Hellwig <hch@infradead.org>
To: Dave Jiang <dave.jiang@intel.com>
Cc: darrick.wong@oracle.com, linux-nvdimm@lists.01.org,
david@fromorbit.com, linux-xfs@vger.kernel.org,
ross.zwisler@linux.intel.com, linux-ext4@vger.kernel.org,
dan.j.williams@intel.com
Subject: Re: [PATCH v5 3/3] xfs: reject removal of realtime flag when datadev doesn't support DAX
Date: Thu, 15 Feb 2018 13:47:08 -0800 [thread overview]
Message-ID: <20180215214708.GA10446@infradead.org> (raw)
In-Reply-To: <151873085471.53899.4916392112937742603.stgit@djiang5-desk3.ch.intel.com>
> + if ((XFS_IS_REALTIME_INODE(ip)) &&
No need for the inner braces.
Except for that the whole series looks fine to me.
next prev parent reply other threads:[~2018-02-15 21:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-15 21:40 [PATCH v5 0/3] minimal DAX support for XFS realtime device Dave Jiang
[not found] ` <151873070632.53899.3320294279108510082.stgit-Cxk7aZI4ujnJARH06PadV2t3HXsI98Cx0E9HWUfgJXw@public.gmane.org>
2018-02-15 21:40 ` [PATCH v5 1/3] fs: allow per-device dax status checking for filesystems Dave Jiang
2018-02-18 8:10 ` kbuild test robot
2018-02-15 21:40 ` [PATCH v5 3/3] xfs: reject removal of realtime flag when datadev doesn't support DAX Dave Jiang
2018-02-15 21:47 ` Christoph Hellwig [this message]
2018-02-15 22:44 ` Dave Jiang
[not found] ` <7657c80b-412b-e280-f126-a7d735a0a730-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2018-02-15 22:48 ` Christoph Hellwig
2018-02-15 21:40 ` [PATCH v5 2/3] dax: change bdev_dax_supported() to support boolean returns Dave Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180215214708.GA10446@infradead.org \
--to=hch@infradead.org \
--cc=dan.j.williams@intel.com \
--cc=darrick.wong@oracle.com \
--cc=dave.jiang@intel.com \
--cc=david@fromorbit.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linux-xfs@vger.kernel.org \
--cc=ross.zwisler@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).