* [PATCH] ext4 : fix comments in ext4_swap_extents
@ 2018-03-24 7:28 zhenwei.pi
2018-03-26 5:46 ` Theodore Y. Ts'o
0 siblings, 1 reply; 6+ messages in thread
From: zhenwei.pi @ 2018-03-24 7:28 UTC (permalink / raw)
To: tytso, adilger.kernel; +Cc: zhenwei.pi, linux-ext4, linux-kernel
"mark_unwritten" in comment and "unwritten" in variable
argument lists is mismatch.
Signed-off-by: zhenwei.pi <zhenwei.pi@youruncloud.com>
---
fs/ext4/extents.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index 054416e..2fc4227 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -5751,7 +5751,7 @@ int ext4_insert_range(struct inode *inode, loff_t offset, loff_t len)
* @lblk1: Start block for first inode
* @lblk2: Start block for second inode
* @count: Number of blocks to swap
- * @mark_unwritten: Mark second inode's extents as unwritten after swap
+ * @unwritten: Mark second inode's extents as unwritten after swap
* @erp: Pointer to save error value
*
* This helper routine does exactly what is promise "swap extents". All other
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] ext4 : fix comments in ext4_swap_extents
@ 2018-03-19 8:34 zhenwei.pi
2018-04-19 14:50 ` Jan Kara
0 siblings, 1 reply; 6+ messages in thread
From: zhenwei.pi @ 2018-03-19 8:34 UTC (permalink / raw)
To: tytso, adilger.kernel; +Cc: zhenwei.pi, linux-ext4, linux-kernel
"mark_unwritten" in comment and "unwritten" in variable
argument lists is mismatch.
Signed-off-by: zhenwei.pi <zhenwei.pi@youruncloud.com>
---
fs/ext4/extents.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index 054416e..2fc4227 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -5751,7 +5751,7 @@ int ext4_insert_range(struct inode *inode, loff_t offset, loff_t len)
* @lblk1: Start block for first inode
* @lblk2: Start block for second inode
* @count: Number of blocks to swap
- * @mark_unwritten: Mark second inode's extents as unwritten after swap
+ * @unwritten: Mark second inode's extents as unwritten after swap
* @erp: Pointer to save error value
*
* This helper routine does exactly what is promise "swap extents". All other
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ext4 : fix comments in ext4_swap_extents
2018-03-19 8:34 zhenwei.pi
@ 2018-04-19 14:50 ` Jan Kara
2018-04-19 16:44 ` Theodore Y. Ts'o
0 siblings, 1 reply; 6+ messages in thread
From: Jan Kara @ 2018-04-19 14:50 UTC (permalink / raw)
To: zhenwei.pi; +Cc: tytso, adilger.kernel, linux-ext4, linux-kernel
On Mon 19-03-18 16:34:09, zhenwei.pi wrote:
> "mark_unwritten" in comment and "unwritten" in variable
> argument lists is mismatch.
>
> Signed-off-by: zhenwei.pi <zhenwei.pi@youruncloud.com>
This seems to have fallen through cracks. The patch looks good to me. Ted,
can you please merge it? Thanks!
Honza
> ---
> fs/ext4/extents.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
> index 054416e..2fc4227 100644
> --- a/fs/ext4/extents.c
> +++ b/fs/ext4/extents.c
> @@ -5751,7 +5751,7 @@ int ext4_insert_range(struct inode *inode, loff_t offset, loff_t len)
> * @lblk1: Start block for first inode
> * @lblk2: Start block for second inode
> * @count: Number of blocks to swap
> - * @mark_unwritten: Mark second inode's extents as unwritten after swap
> + * @unwritten: Mark second inode's extents as unwritten after swap
> * @erp: Pointer to save error value
> *
> * This helper routine does exactly what is promise "swap extents". All other
> --
> 2.7.4
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ext4 : fix comments in ext4_swap_extents
2018-04-19 14:50 ` Jan Kara
@ 2018-04-19 16:44 ` Theodore Y. Ts'o
2018-04-19 20:13 ` Jan Kara
0 siblings, 1 reply; 6+ messages in thread
From: Theodore Y. Ts'o @ 2018-04-19 16:44 UTC (permalink / raw)
To: Jan Kara; +Cc: zhenwei.pi, adilger.kernel, linux-ext4, linux-kernel
On Thu, Apr 19, 2018 at 04:50:28PM +0200, Jan Kara wrote:
> On Mon 19-03-18 16:34:09, zhenwei.pi wrote:
> > "mark_unwritten" in comment and "unwritten" in variable
> > argument lists is mismatch.
> >
> > Signed-off-by: zhenwei.pi <zhenwei.pi@youruncloud.com>
>
> This seems to have fallen through cracks. The patch looks good to me. Ted,
> can you please merge it? Thanks!
It landed in 4.17-rc1, commit id: dcae058a8da9c
Cheers,
- Ted
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ext4 : fix comments in ext4_swap_extents
2018-04-19 16:44 ` Theodore Y. Ts'o
@ 2018-04-19 20:13 ` Jan Kara
0 siblings, 0 replies; 6+ messages in thread
From: Jan Kara @ 2018-04-19 20:13 UTC (permalink / raw)
To: Theodore Y. Ts'o
Cc: Jan Kara, zhenwei.pi, adilger.kernel, linux-ext4, linux-kernel
On Thu 19-04-18 12:44:56, Theodore Y. Ts'o wrote:
> On Thu, Apr 19, 2018 at 04:50:28PM +0200, Jan Kara wrote:
> > On Mon 19-03-18 16:34:09, zhenwei.pi wrote:
> > > "mark_unwritten" in comment and "unwritten" in variable
> > > argument lists is mismatch.
> > >
> > > Signed-off-by: zhenwei.pi <zhenwei.pi@youruncloud.com>
> >
> > This seems to have fallen through cracks. The patch looks good to me. Ted,
> > can you please merge it? Thanks!
>
> It landed in 4.17-rc1, commit id: dcae058a8da9c
Ah, somehow I missed that. Sorry.
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-04-19 20:13 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-24 7:28 [PATCH] ext4 : fix comments in ext4_swap_extents zhenwei.pi
2018-03-26 5:46 ` Theodore Y. Ts'o
-- strict thread matches above, loose matches on Subject: below --
2018-03-19 8:34 zhenwei.pi
2018-04-19 14:50 ` Jan Kara
2018-04-19 16:44 ` Theodore Y. Ts'o
2018-04-19 20:13 ` Jan Kara
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).