From: Mathieu Malaterre <malat@debian.org>
To: tytso@mit.edu
Cc: Milan Kupcevic <milan@debian.org>,
Ben Hutchings <ben@decadent.org.uk>,
Mathieu Malaterre <malat@debian.org>,
Andreas Dilger <adilger.kernel@dilger.ca>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] fs: Add MODULE_SOFTDEP declarations for hard-coded crypto drivers
Date: Fri, 6 Apr 2018 21:52:31 +0200 [thread overview]
Message-ID: <20180406195231.14868-1-malat@debian.org> (raw)
This helps initramfs builders and other tools to find the full
dependencies of a module.
Debian on powerpc (ppc32) still uses yaboot as default boot loader. Using a
default installation (debian-installer) 64bit and metadata_csum feature are
not setup in ext4. This is discussed in more details at:
https://bugs.debian.org/825110#81
and implemented here:
https://anonscm.debian.org/cgit/d-i/partman-ext3.git/patch/?id=f87dc92157262de1ad8dd3f2343436f08271b4dc
This means that building the kernel as default debian package:
make ARCH=powerpc XYZ_defconfig
make -j8 ARCH=powerpc CROSS_COMPILE=powerpc-linux-gnu- bindeb-pkg
Will lead to the following boot failure (initramfs prompt):
/dev/sda3: clean, 127679/305216 files, 11128559/1220703 blocks done.
[ 5.592819] EXT4-fs (sda3): Cannot load crc32c driver.
mount: mounting /dev/sda3 on /root failed: No such file or directory
Link: https://bugs.debian.org/819725
Link: https://salsa.debian.org/kernel-team/linux/blob/master/debian/patches/bugfix/all/fs-add-module_softdep-declarations-for-hard-coded-cr.patch
Suggested-by: Ben Hutchings <ben@decadent.org.uk>
Cc: Milan Kupcevic <milan@debian.org>
Signed-off-by: Mathieu Malaterre <malat@debian.org>
---
fs/ext4/super.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 185f7e61f4cf..10bda040e78f 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -5886,5 +5886,6 @@ static void __exit ext4_exit_fs(void)
MODULE_AUTHOR("Remy Card, Stephen Tweedie, Andrew Morton, Andreas Dilger, Theodore Ts'o and others");
MODULE_DESCRIPTION("Fourth Extended Filesystem");
MODULE_LICENSE("GPL");
+MODULE_SOFTDEP("pre: crypto-crc32c");
module_init(ext4_init_fs)
module_exit(ext4_exit_fs)
--
2.11.0
next reply other threads:[~2018-04-06 19:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-06 19:52 Mathieu Malaterre [this message]
2018-05-02 8:01 ` [PATCH] fs: Add MODULE_SOFTDEP declarations for hard-coded crypto drivers Mathieu Malaterre
-- strict thread matches above, loose matches on Subject: below --
2016-05-17 13:36 Ben Hutchings
2016-05-17 14:59 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180406195231.14868-1-malat@debian.org \
--to=malat@debian.org \
--cc=adilger.kernel@dilger.ca \
--cc=ben@decadent.org.uk \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=milan@debian.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox