From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Lukas Czerner <lczerner@redhat.com>
Cc: linux-ext4@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] ext4: fix bitmap position validation
Date: Mon, 30 Apr 2018 12:45:07 -0400 [thread overview]
Message-ID: <20180430164507.GC20585@thunk.org> (raw)
In-Reply-To: <20180430082453.c7b6lihc6v46jyfe@rh_laptop>
On Mon, Apr 30, 2018 at 10:24:53AM +0200, Lukas Czerner wrote:
>
> Well, so much for a discussion :-/ The patch is upstream now...
Sorry, it's been crazy busy and there were other fixes I really needed
to get upstream.
If it really is superfluous, the compiler will optimize it away. I
have been bitten more times than I can count with fuzz testers and C's
_fine_ signed vs. unsigned integer semantics. So I prefer to be
careful here.
If we can really be sure it's safe, we can always remove the extra
comparison in a separate patch, since that's unrelated to the real bug
we're trying to fix.
- Ted
next prev parent reply other threads:[~2018-04-30 16:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-24 10:56 [PATCH] ext4: fix bitmap position validation Lukas Czerner
2018-04-24 15:43 ` Theodore Y. Ts'o
2018-04-25 7:39 ` Lukas Czerner
2018-04-30 8:24 ` Lukas Czerner
2018-04-30 16:45 ` Theodore Y. Ts'o [this message]
2018-05-02 11:44 ` Lukas Czerner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180430164507.GC20585@thunk.org \
--to=tytso@mit.edu \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).