From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Jan Kara <jack@suse.cz>
Cc: linux-ext4@vger.kernel.org, Jeff Mahoney <jeffm@suse.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] ext4: Fix hole length detection in ext4_ind_map_blocks()
Date: Sun, 13 May 2018 15:50:42 -0400 [thread overview]
Message-ID: <20180513195042.GE14763@thunk.org> (raw)
In-Reply-To: <20180510153851.4689-1-jack@suse.cz>
On Thu, May 10, 2018 at 05:38:51PM +0200, Jan Kara wrote:
> When ext4_ind_map_blocks() computes a length of a hole, it doesn't count
> with the fact that mapped offset may be somewhere in the middle of the
> completely empty subtree. In such case it will return too large length
> of the hole which then results in lseek(SEEK_DATA) to end up returning
> an incorrect offset beyond the end of the hole.
>
> Fix the problem by correctly taking offset within a subtree into account
> when computing a length of a hole.
>
> Fixes: facab4d9711e7aa3532cb82643803e8f1b9518e8
> CC: stable@vger.kernel.org
> Reported-by: Jeff Mahoney <jeffm@suse.com>
> Signed-off-by: Jan Kara <jack@suse.cz>
Applied, thanks.
- Ted
prev parent reply other threads:[~2018-05-13 19:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-10 15:38 [PATCH] ext4: Fix hole length detection in ext4_ind_map_blocks() Jan Kara
2018-05-13 19:50 ` Theodore Y. Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180513195042.GE14763@thunk.org \
--to=tytso@mit.edu \
--cc=jack@suse.cz \
--cc=jeffm@suse.com \
--cc=linux-ext4@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).