From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Lukas Czerner <lczerner@redhat.com>
Cc: linux-ext4@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] ext4: update mtime in ext4_punch_hole even if no blocks are released
Date: Sun, 13 May 2018 19:39:00 -0400 [thread overview]
Message-ID: <20180513233900.GH14763@thunk.org> (raw)
In-Reply-To: <1524575271-27142-1-git-send-email-lczerner@redhat.com>
On Tue, Apr 24, 2018 at 03:07:51PM +0200, Lukas Czerner wrote:
> Currently in ext4_punch_hole we're going to skip the mtime update if
> there are no actual blocks to release. However we've actually modified
> the file by zeroing the partial block so the mtime should be updated.
>
> Moreover the sync and datasync handling is skipped as well, which is
> also wrong. Fix it.
>
> Signed-off-by: Lukas Czerner <lczerner@redhat.com>
> Reported-by: Joe Habermann <joe.habermann@quantum.com>
> Cc: <stable@vger.kernel.org>
Thanks, applied.
- Ted
prev parent reply other threads:[~2018-05-13 23:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-24 13:07 [PATCH] ext4: update mtime in ext4_punch_hole even if no blocks are released Lukas Czerner
2018-05-13 23:39 ` Theodore Y. Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180513233900.GH14763@thunk.org \
--to=tytso@mit.edu \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).