From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Wang Long <wanglong19@meituan.com>
Cc: darrick.wong@oracle.com, jack@suse.com,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] jbd2: remove the conditional test
Date: Sun, 20 May 2018 22:41:09 -0400 [thread overview]
Message-ID: <20180521024109.GF4464@thunk.org> (raw)
In-Reply-To: <1517840679-5902-1-git-send-email-wanglong19@meituan.com>
On Mon, Feb 05, 2018 at 10:24:39PM +0800, Wang Long wrote:
> kmem_cache_destroy already handles null pointers, so we can remove the
> conditional test entirely.
>
> This patch also set NULL after the kmem_cache_destroy in function
> jbd2_journal_destroy_handle_cache.
>
> Signed-off-by: Wang Long <wanglong19@meituan.com>
Thanks; I clarified the patch summary to be:
jbd2: remove NULL check before calling kmem_cache_destroy()
and have applied it. Apologies for not getting to this earlier.
- Ted
prev parent reply other threads:[~2018-05-21 2:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-05 14:24 [PATCH] jbd2: remove the conditional test Wang Long
2018-02-06 10:22 ` Jan Kara
2018-05-21 2:41 ` Theodore Y. Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180521024109.GF4464@thunk.org \
--to=tytso@mit.edu \
--cc=darrick.wong@oracle.com \
--cc=jack@suse.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wanglong19@meituan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).