linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eryu Guan <guaneryu-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Ross Zwisler <ross.zwisler-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Cc: Jan Kara <jack-AlSwsSmVLrQ@public.gmane.org>,
	linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org,
	Dave Chinner <david-FqsqvQoI3Ljby3iVrkZq2A@public.gmane.org>,
	fstests-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
Subject: Re: [fstests PATCH 1/2] src/: fix up mmap() error checking
Date: Fri, 22 Jun 2018 10:28:38 +0800	[thread overview]
Message-ID: <20180622022838.GM2780@desktop> (raw)
In-Reply-To: <20180620225147.12151-1-ross.zwisler-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>

On Wed, Jun 20, 2018 at 04:51:46PM -0600, Ross Zwisler wrote:
> I noticed that in some of my C tests in src/ I was incorrectly checking for
> mmap() failure by looking for NULL instead of MAP_FAILED.  Fix those and
> clean up some places where we were testing against -1 (the actual value of
> MAP_FAILED) which was manually being cast to a pointer.
> 
> Signed-off-by: Ross Zwisler <ross.zwisler-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>

BTW, I've applied this patch, no need to resend it in v2.

Thanks,
Eryu

  parent reply	other threads:[~2018-06-22  2:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-20 22:51 [fstests PATCH 1/2] src/: fix up mmap() error checking Ross Zwisler
     [not found] ` <20180620225147.12151-1-ross.zwisler-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2018-06-20 22:51   ` [fstests PATCH 2/2] generic/999: test DAX DMA vs truncate/hole-punch Ross Zwisler
     [not found]     ` <20180620225147.12151-2-ross.zwisler-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2018-06-21  2:18       ` Dave Chinner
2018-06-21 16:34         ` Ross Zwisler
2018-06-21  2:40       ` Eryu Guan
2018-07-10 21:15         ` Ross Zwisler
2018-06-22  2:28   ` Eryu Guan [this message]
2018-06-22 16:19     ` [fstests PATCH 1/2] src/: fix up mmap() error checking Ross Zwisler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180622022838.GM2780@desktop \
    --to=guaneryu-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=david-FqsqvQoI3Ljby3iVrkZq2A@public.gmane.org \
    --cc=fstests-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=hch-jcswGhMUV9g@public.gmane.org \
    --cc=jack-AlSwsSmVLrQ@public.gmane.org \
    --cc=linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org \
    --cc=ross.zwisler-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).