From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 1/1] iomap: Direct I/O for inline data Date: Fri, 29 Jun 2018 18:01:48 +0200 Message-ID: <20180629160148.GA9938@lst.de> References: <20180627003906.15571-1-agruenba@redhat.com> <20180627003906.15571-2-agruenba@redhat.com> <20180629085614.GB16042@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: cluster-devel , linux-fsdevel , linux-ext4 , Christoph Hellwig To: Andreas Gruenbacher Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: cluster-devel-bounces@redhat.com Errors-To: cluster-devel-bounces@redhat.com List-Id: linux-ext4.vger.kernel.org On Fri, Jun 29, 2018 at 04:40:40PM +0200, Andreas Gruenbacher wrote: > On 29 June 2018 at 10:56, Christoph Hellwig wrote: > > This looks generally fine. But I think it might be worth refactoring > > iomap_dio_actor a bit first, e.g. something like this new patch > > before yours, which would also nicely solve your alignmnet concern > > (entirely untested for now): > > This looks correct. I've rebased my patches on top of it and I ran the > xfstest auto group on gfs2 and xfs on top. > > Can you push this to your gfs2-iomap branch? I'll then repost an > updated version of "iomap: Direct I/O for inline data". Darrick now has a real iomap merge branch which replaced it. Before formally submitting the patch I'd also like to verify that it does not regress for XFS by doing a full xfstests run.