Re: [PATCH v2 1/2] dax: dax_layout_busy_page() warn on !exceptional

Ross Zwisler
2018-07-03T15:41:37Z

On Mon, Jul 02, 2018 at 06:15:03PM -0400, Theodore Y. Ts'o wrote:
> On Wed, Jun 27, 2018 at 03:22:51PM -0600, Ross Zwisler wrote:
> > Inodes using DAX should only ever have exceptional entries in their page
> > caches. Make this clear by warning if the iteration in
> > dax_layout_busy_page() ever sees a non-exceptional entry, and by adding a
> > comment for the pagevec_release() call which only deals with struct page
> > pointers.
> >
> > Signed-off-by: Ross Zwisler <ross.zwisler-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
> > Reviewed-by: Jan Kara <jack-AlSwsSmVLrQ@public.gmane.org>
>
> Thanks, applied (to the ext4 tree). If someone thinks they should go
> in via some other tree, holler.
>
> - Ted

Hey Ted,

It looks like you only picked up patch 1/2? (I'm looking at the 'dev' branch
in your repo.) Was that intentional?

You can find the final version of the 2nd patch here:

https://lists.01.org/pipermail/linux-nvdimm/2018-July/016602.html

Thanks,
- Ross