From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: "이준일/연구원/MC연구소 BSP실 BSP6팀(junil0814.lee@lge.com)"
<junil0814.lee@lge.com>
Cc: adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org,
linux-kernel@vger.kernel.org, junil0814.lee@MIT.EDU
Subject: Re: [PATCH] ext4: remove abnormal set for I_DATA_SEM subclass
Date: Mon, 23 Jul 2018 12:23:38 -0400 [thread overview]
Message-ID: <20180723162338.GG3358@thunk.org> (raw)
In-Reply-To: <ccb7943b-44af-5031-8410-f1c0851e70c2@lge.com>
On Mon, Jul 23, 2018 at 10:48:37AM +0900, 이준일/연구원/MC연구소 BSP실 BSP6팀(junil0814.lee@lge.com) wrote:
> Then, I have a question.
> quotactl() doesn't have case only to set limits flag, the routine to set
> the DQUOT_LIMITS_ENABLED flag is under dquot_enable() function.
> According to this logic, if users makes duplicate request to set
> DQUOT_LIMITS_ENABLED flags, can lockdep make the false alarm with ext4 ?
With the upstream kernel, if you call quotactl with the Q_QUOTAON
command, it will fail with EEXIST before it ever gets to the file
system specific quota code. This happens in dquot_quota_enable() in
fs/quota/dquot.c.
I'm going to guess you didn't try to reproduce the problem with the
latest mainstream kernel, and then applied the patch, and verified the
problem went away before you submitted it?
Regards,
- Ted
next prev parent reply other threads:[~2018-07-23 16:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-09 7:58 [PATCH] ext4: remove abnormal set for I_DATA_SEM subclass Junil Lee
2018-07-22 22:08 ` Theodore Y. Ts'o
[not found] ` <ccb7943b-44af-5031-8410-f1c0851e70c2@lge.com>
2018-07-23 16:23 ` Theodore Y. Ts'o [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-07-09 6:08 Junil Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180723162338.GG3358@thunk.org \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=junil0814.lee@MIT.EDU \
--cc=junil0814.lee@lge.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).