From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Andreas Dilger <adilger@dilger.ca>
Cc: Jeremy Cline <jcline@redhat.com>, Theodore Ts'o <tytso@mit.edu>,
linux-ext4 <linux-ext4@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
stable@vger.kernel.org
Subject: Re: [PATCH 1/3] ext4: super: Fix spectre gadget in ext4_quota_on
Date: Tue, 31 Jul 2018 12:31:36 -0500 [thread overview]
Message-ID: <20180731173136.rnhzvvvt3wtt2xdg@treble> (raw)
In-Reply-To: <E3E7B6AF-3819-4998-9B12-DACB4EBC14F1@dilger.ca>
On Tue, Jul 31, 2018 at 12:39:41AM -0600, Andreas Dilger wrote:
> > Also it looks like XQM_MAXQUOTAS, MAXQUOTAS, and EXT4_MAXQUOTAS all
> > have the same value (3). Maybe they can be consolidated to just use
> > MAXQUOTAS everywhere?
>
> No, the filesystem-specific MAXQUOTAS values were separated from
> the kernel MAXQUOTAS value for a good reason. This allows some
> filesystems to support new quota types (e.g. project quotas) that
> not all other filesystems can handle. This may potentially change
> again in the future, so they shouldn't be tightly coupled.
But isn't that what sb->s_quota_types is for? To allow different
filesystems to support different quota types?
Also I don't see any bounds checks for EXT4_MAXQUOTAS. It seems like
the ext4 code assumes that MAXQUOTAS and EXT4_MAXQUOTAS are the same.
--
Josh
next prev parent reply other threads:[~2018-07-31 17:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-27 16:23 [PATCH 0/3] ext4: fix spectre v1 gadgets Jeremy Cline
2018-07-27 16:23 ` [PATCH 1/3] ext4: super: Fix spectre gadget in ext4_quota_on Jeremy Cline
2018-07-27 17:46 ` Josh Poimboeuf
2018-07-27 19:17 ` Jeremy Cline
2018-07-31 6:39 ` Andreas Dilger
2018-07-31 17:31 ` Josh Poimboeuf [this message]
2018-07-27 16:23 ` [PATCH 2/3] ext4: super: Fix spectre gadgets in ext4_quota_{read,write,off} Jeremy Cline
2018-07-27 16:23 ` [PATCH 3/3] ext4: mballoc: Fix spectre gadget in ext4_mb_simple_scan_group Jeremy Cline
2018-07-27 18:10 ` Josh Poimboeuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180731173136.rnhzvvvt3wtt2xdg@treble \
--to=jpoimboe@redhat.com \
--cc=adilger@dilger.ca \
--cc=jcline@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox