From: Matthew Wilcox <willy@infradead.org>
To: Souptick Joarder <jrdr.linux@gmail.com>
Cc: "Theodore Y. Ts'o" <tytso@mit.edu>,
adilger.kernel@dilger.ca,
"Darrick J. Wong" <darrick.wong@oracle.com>,
Jens Axboe <axboe@kernel.dk>,
Andreas Gruenbacher <agruenba@redhat.com>,
Eric Biggers <ebiggers@google.com>,
Greg KH <gregkh@linuxfoundation.org>,
kemi.wang@intel.com,
Sabyasachi Gupta <sabyasachi.linux@gmail.com>,
Brajeswar Ghosh <brajeswar.linux@gmail.com>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ext4: Convert int to vm_fault_t type
Date: Wed, 1 Aug 2018 06:13:30 -0700 [thread overview]
Message-ID: <20180801131330.GA4734@bombadil.infradead.org> (raw)
In-Reply-To: <CAFqt6zbxpj5DS=ONUGTJ9zaeH5k=qZpQYy-J+08tr9y0gOsCAg@mail.gmail.com>
On Wed, Aug 01, 2018 at 06:34:45PM +0530, Souptick Joarder wrote:
> > The fact that ext4_page_mkwrite() returns a vm_fault_t, while
> > block_page_mkwrite() returns an int which then has to get translated
> > into a vm_fault_t via block_page_mkwrite_return() is I suspect going
> > to confuse an awful lot of callers.
>
> We have also changed block_page_mkwrite() to return vm_fault_t, but in
> a different patch. Hopefully that patch will be in linux-next tree soon.
I didn't sign off on that, so that's not "we", but "I". And this is
completely against everything I've been telling you for this whole effort.
Patches should each make sense individually. You can't make this patch
dependent on another patch without putting that in writing.
Leave block_page_mkwrite() alone for now. Eventually it should return
a vm_fault_t, probably. But that patch needs to be delayed at least
one kernel cycle.
next prev parent reply other threads:[~2018-08-01 13:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-28 8:50 [PATCH] ext4: Convert int to vm_fault_t type Souptick Joarder
2018-07-28 8:49 ` Souptick Joarder
2018-08-01 12:55 ` Theodore Y. Ts'o
2018-08-01 13:04 ` Souptick Joarder
2018-08-01 13:11 ` Souptick Joarder
2018-08-01 13:13 ` Matthew Wilcox [this message]
2018-08-01 13:26 ` Souptick Joarder
2018-08-01 14:38 ` Theodore Y. Ts'o
2018-08-01 16:06 ` Theodore Y. Ts'o
2018-08-01 16:13 ` Matthew Wilcox
2018-08-01 16:22 ` Theodore Y. Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180801131330.GA4734@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=adilger.kernel@dilger.ca \
--cc=agruenba@redhat.com \
--cc=axboe@kernel.dk \
--cc=brajeswar.linux@gmail.com \
--cc=darrick.wong@oracle.com \
--cc=ebiggers@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=jrdr.linux@gmail.com \
--cc=kemi.wang@intel.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sabyasachi.linux@gmail.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).