From: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
To: Dave Chinner <david-FqsqvQoI3Ljby3iVrkZq2A@public.gmane.org>
Cc: Jan Kara <jack-AlSwsSmVLrQ@public.gmane.org>,
linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org,
darrick.wong-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org,
linux-xfs <linux-xfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Ross Zwisler <zwisler-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
linux-fsdevel
<linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
lczerner-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
linux-ext4 <linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
Subject: Re: [PATCH v4 0/2] ext4: fix DAX dma vs truncate/hole-punch
Date: Mon, 6 Aug 2018 17:49:43 +0200 [thread overview]
Message-ID: <20180806154943.GA17666@lst.de> (raw)
In-Reply-To: <20180806035550.GE7395@dastard>
> > > This allows the direct I/O path to do I/O and raise & lower page->_refcount
> > > while we're executing a truncate/hole punch. This leads to us trying to free
> > > a page with an elevated refcount.
>
> I don't see how this is possible in XFS - maybe I'm missing
> something, but "direct IO submission during truncate" is not
> something that should ever be happening in XFS, DAX or not.
The pages involved in a direct I/O are not that of the file that
the direct I/O read/write syscalls are called on, but those of the
memory regions the direct I/O read/write syscalls operate on.
Those pages could be file backed and undergo a truncate at the
same time.
next prev parent reply other threads:[~2018-08-06 15:49 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-10 19:10 [PATCH v4 0/2] ext4: fix DAX dma vs truncate/hole-punch Ross Zwisler
[not found] ` <20180710191031.17919-1-ross.zwisler-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2018-07-10 19:10 ` [PATCH v4 1/2] dax: dax_layout_busy_page() warn on !exceptional Ross Zwisler
[not found] ` <20180710191031.17919-2-ross.zwisler-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2018-08-10 19:52 ` Eric Sandeen
[not found] ` <6ca60cf6-f1dc-27d5-fb79-7547aea39dfa-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-08-10 20:33 ` Theodore Y. Ts'o
[not found] ` <20180810203349.GH627-AKGzg7BKzIDYtjvyW6yDsg@public.gmane.org>
2018-08-11 2:10 ` Theodore Y. Ts'o
[not found] ` <20180811021053.GB14368-AKGzg7BKzIDYtjvyW6yDsg@public.gmane.org>
2018-08-13 10:12 ` Jan Kara
[not found] ` <20180813101252.GC8927-4I4JzKEfoa/jFM9bn6wA6Q@public.gmane.org>
2018-08-13 12:46 ` Theodore Y. Ts'o
2018-08-24 15:44 ` Jan Kara
2018-08-27 16:09 ` Jan Kara
2018-07-10 19:10 ` [PATCH v4 2/2] ext4: handle layout changes to pinned DAX mappings Ross Zwisler
2018-07-11 8:17 ` [PATCH v4 0/2] ext4: fix DAX dma vs truncate/hole-punch Jan Kara
[not found] ` <20180711081741.lmr44sp4cmt3f6um-4I4JzKEfoa/jFM9bn6wA6Q@public.gmane.org>
2018-07-11 15:41 ` Ross Zwisler
2018-07-25 22:28 ` Ross Zwisler
[not found] ` <20180725222839.GA28304-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2018-07-27 16:28 ` Ross Zwisler
[not found] ` <CAOxpaSWCT+XRtGxGQT_PVMcn79csMxbqb+cf4yycbV3eqjjnkQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-08-06 3:55 ` Dave Chinner
2018-08-06 15:49 ` Christoph Hellwig [this message]
[not found] ` <20180806154943.GA17666-jcswGhMUV9g@public.gmane.org>
2018-08-06 22:25 ` Dave Chinner
2018-08-07 8:45 ` Jan Kara
[not found] ` <20180807084545.6gzxrtrvb34hyhdq-4I4JzKEfoa/jFM9bn6wA6Q@public.gmane.org>
2018-09-10 22:18 ` Eric Sandeen
[not found] ` <8c70d61a-fc5c-b928-334a-fbb2567b8dea-+82itfer+wXR7s880joybQ@public.gmane.org>
2018-09-11 15:14 ` Jan Kara
[not found] ` <20180911151421.GD6104-4I4JzKEfoa/jFM9bn6wA6Q@public.gmane.org>
2018-09-11 15:20 ` Jan Kara
[not found] ` <20180911152024.GE6104-4I4JzKEfoa/jFM9bn6wA6Q@public.gmane.org>
2018-09-11 17:28 ` Theodore Y. Ts'o
[not found] ` <20180911172806.GC2225-AKGzg7BKzIDYtjvyW6yDsg@public.gmane.org>
2018-09-11 18:21 ` Eric Sandeen
2018-07-31 19:44 ` Ross Zwisler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180806154943.GA17666@lst.de \
--to=hch-jcswghmuv9g@public.gmane.org \
--cc=darrick.wong-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
--cc=david-FqsqvQoI3Ljby3iVrkZq2A@public.gmane.org \
--cc=jack-AlSwsSmVLrQ@public.gmane.org \
--cc=lczerner-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org \
--cc=linux-xfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=zwisler-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).