From: Toshi Kani <toshi.kani-ZPxbGqLxI0U@public.gmane.org>
To: jack-AlSwsSmVLrQ@public.gmane.org,
dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org
Cc: adilger.kernel-m1MBpc4rdrD3fQ9qLvQP4Q@public.gmane.org,
linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
tytso-3s7WtUTddSA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org
Subject: [PATCH 0/2] fix sync to flush processor cache for ext4 DAX files
Date: Tue, 11 Sep 2018 09:42:44 -0600 [thread overview]
Message-ID: <20180911154246.6844-1-toshi.kani@hpe.com> (raw)
This patchset fixes an issue that sync syscall to an existing DAX file
does not flush processor cache.
Patch 1/2 adds a check to skip the journal inode. It's a bit awkward,
but I could not find a beter way to get the journal inode.
Patch 2/2 fixes the issue by moving up ext4_set_inode_flags() before
ext4_set_aops() in ext4_iget(). This assumes updated i_flags is harmless
in the error cases after the moved-up ext4_set_inode_flags(). Please
review.
---
Toshi Kani (2):
1/2 ext4, dax: update dax check to skip journal inode
2/2 ext4, dax: set ext4_dax_aops for dax files
---
fs/ext4/ext4_jbd2.h | 8 ++++++++
fs/ext4/inode.c | 5 ++++-
2 files changed, 12 insertions(+), 1 deletion(-)
next reply other threads:[~2018-09-11 15:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-11 15:42 Toshi Kani [this message]
[not found] ` <20180911154246.6844-1-toshi.kani-ZPxbGqLxI0U@public.gmane.org>
2018-09-11 15:42 ` [PATCH 1/2] ext4, dax: update dax check to skip journal inode Toshi Kani
2018-09-11 17:59 ` Dan Williams
2018-09-11 18:11 ` Kani, Toshi
2018-09-12 9:24 ` Jan Kara
[not found] ` <20180912092422.GA7782-4I4JzKEfoa/jFM9bn6wA6Q@public.gmane.org>
2018-09-12 15:47 ` Kani, Toshi
2018-09-12 16:20 ` Jan Kara
[not found] ` <20180912162046.GA23522-4I4JzKEfoa/jFM9bn6wA6Q@public.gmane.org>
2018-09-12 16:52 ` Kani, Toshi
2018-09-11 15:42 ` [PATCH 2/2] ext4, dax: set ext4_dax_aops for dax files Toshi Kani
[not found] ` <20180911154246.6844-3-toshi.kani-ZPxbGqLxI0U@public.gmane.org>
2018-09-11 18:15 ` Dan Williams
[not found] ` <CAPcyv4iEZ7q0MV7n-_eovrJw_U9S3=pkY_nYwtw1jSBS7vPqCQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-09-11 18:41 ` Kani, Toshi
2018-09-12 9:31 ` Jan Kara
[not found] ` <20180912093140.GB7782-4I4JzKEfoa/jFM9bn6wA6Q@public.gmane.org>
2018-09-12 16:08 ` Kani, Toshi
2018-09-12 16:41 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180911154246.6844-1-toshi.kani@hpe.com \
--to=toshi.kani-zpxbgqlxi0u@public.gmane.org \
--cc=adilger.kernel-m1MBpc4rdrD3fQ9qLvQP4Q@public.gmane.org \
--cc=dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=jack-AlSwsSmVLrQ@public.gmane.org \
--cc=linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org \
--cc=tytso-3s7WtUTddSA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).