From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Wang Shilong <wangshilong1991@gmail.com>
Cc: adilger@dilger.ca, linux-ext4@vger.kernel.org, wshilong@ddn.com,
dchinner@redhat.com, linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [PATCH v3 1/3] ext4: fix setattr project check upon fssetxattr ioctl
Date: Sat, 15 Sep 2018 23:55:29 -0400 [thread overview]
Message-ID: <20180916035529.GG8652@thunk.org> (raw)
In-Reply-To: <1536710238-16858-1-git-send-email-wshilong1991@gmail.com>
On Wed, Sep 12, 2018 at 08:57:16AM +0900, Wang Shilong wrote:
> diff --git a/fs/ext4/ioctl.c b/fs/ext4/ioctl.c
> index a7074115d6f6..f81102bd3203 100644
> --- a/fs/ext4/ioctl.c
> +++ b/fs/ext4/ioctl.c
> @@ -339,19 +339,14 @@ static int ext4_ioctl_setproject(struct file *filp, __u32 projid)
> if (projid_eq(kprojid, EXT4_I(inode)->i_projid))
> return 0;
>
> - err = mnt_want_write_file(filp);
> - if (err)
> - return err;
> -
A huge part of this patch is dropping the calls to
mnt_want_write_file() and mnt_drop_write_file(). What's the
justification for doing this? The use of mnt_want_write_file() looks
necessary to me...
- Ted
next prev parent reply other threads:[~2018-09-16 3:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-11 23:57 [PATCH v3 1/3] ext4: fix setattr project check upon fssetxattr ioctl Wang Shilong
2018-09-11 23:57 ` [PATCH v2 2/3] ext4: fix to detect failure of dquot_initialize in project ioctl Wang Shilong
2018-09-11 23:57 ` [PATCH v4 3/3] f2fs: fix setattr project check upon fssetxattr ioctl Wang Shilong
2018-09-16 3:55 ` Theodore Y. Ts'o [this message]
2018-09-16 4:02 ` [PATCH v3 1/3] ext4: " Wang Shilong
2018-09-16 12:20 ` Theodore Y. Ts'o
2018-09-16 12:25 ` Wang Shilong
2018-09-17 5:18 ` Wang Shilong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180916035529.GG8652@thunk.org \
--to=tytso@mit.edu \
--cc=adilger@dilger.ca \
--cc=dchinner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=wangshilong1991@gmail.com \
--cc=wshilong@ddn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).