* [PATCH RESEND] ext4: Fix build error when DX_DEBUG is defined
@ 2018-09-24 18:15 Gabriel Krisman Bertazi
2018-10-02 17:36 ` Theodore Y. Ts'o
0 siblings, 1 reply; 2+ messages in thread
From: Gabriel Krisman Bertazi @ 2018-09-24 18:15 UTC (permalink / raw)
To: tytso; +Cc: linux-ext4, Gabriel Krisman Bertazi
Enabling DX_DEBUG triggers the build error below. info is an attribute
of the dxroot structure.
linux/fs/ext4/namei.c:2264:12: error: ‘info’
undeclared (first use in this function); did you mean ‘insl’?
info->indirect_levels));
Fixes: e08ac99fa2a2 ("ext4: add largedir feature")
Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.co.uk>
Reviewed-by: Lukas Czerner <lczerner@redhat.com>
---
fs/ext4/namei.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
index 377d516c475f..67a38532032a 100644
--- a/fs/ext4/namei.c
+++ b/fs/ext4/namei.c
@@ -2261,7 +2261,7 @@ static int ext4_dx_add_entry(handle_t *handle, struct ext4_filename *fname,
dxroot->info.indirect_levels += 1;
dxtrace(printk(KERN_DEBUG
"Creating %d level index...\n",
- info->indirect_levels));
+ dxroot->info.indirect_levels));
err = ext4_handle_dirty_dx_node(handle, dir, frame->bh);
if (err)
goto journal_error;
--
2.19.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH RESEND] ext4: Fix build error when DX_DEBUG is defined
2018-09-24 18:15 [PATCH RESEND] ext4: Fix build error when DX_DEBUG is defined Gabriel Krisman Bertazi
@ 2018-10-02 17:36 ` Theodore Y. Ts'o
0 siblings, 0 replies; 2+ messages in thread
From: Theodore Y. Ts'o @ 2018-10-02 17:36 UTC (permalink / raw)
To: Gabriel Krisman Bertazi; +Cc: linux-ext4
On Mon, Sep 24, 2018 at 02:15:24PM -0400, Gabriel Krisman Bertazi wrote:
> Enabling DX_DEBUG triggers the build error below. info is an attribute
> of the dxroot structure.
>
> linux/fs/ext4/namei.c:2264:12: error: ‘info’
> undeclared (first use in this function); did you mean ‘insl’?
> info->indirect_levels));
>
> Fixes: e08ac99fa2a2 ("ext4: add largedir feature")
> Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.co.uk>
> Reviewed-by: Lukas Czerner <lczerner@redhat.com>
Applied, thanks.
- Ted
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-10-03 0:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-24 18:15 [PATCH RESEND] ext4: Fix build error when DX_DEBUG is defined Gabriel Krisman Bertazi
2018-10-02 17:36 ` Theodore Y. Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).