From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Lukas Czerner <lczerner@redhat.com>
Cc: linux-ext4@vger.kernel.org, stable@kernel.org
Subject: Re: [PATCH] ext4: initialize retries variable in ext4_da_write_inline_data_begin()
Date: Tue, 2 Oct 2018 21:24:37 -0400 [thread overview]
Message-ID: <20181003012437.GA18521@thunk.org> (raw)
In-Reply-To: <20180813133459.24241-1-lczerner@redhat.com>
On Mon, Aug 13, 2018 at 03:34:59PM +0200, Lukas Czerner wrote:
> Variable retries is not initialized in ext4_da_write_inline_data_begin()
> which can lead to nondeterministic number of retries in case we hit
> ENOSPC. Initialize retries to zero as we do everywhere else.
>
> Signed-off-by: Lukas Czerner <lczerner@redhat.com>
> Fixes: bc0ca9df3b2a ("ext4: retry allocation when inline->extent conversion failed")
> Cc: stable@kernel.org
Applied, thanks.
- Ted
prev parent reply other threads:[~2018-10-03 8:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180813133459.24241-1-lczerner@redhat.com>
[not found] ` <20180912155448.GB32355@quack2.suse.cz>
2018-09-26 9:01 ` [PATCH] ext4: initialize retries variable in ext4_da_write_inline_data_begin() Lukas Czerner
2018-10-03 1:24 ` Theodore Y. Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181003012437.GA18521@thunk.org \
--to=tytso@mit.edu \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).