linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: nicholas.clark@gmail.com
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH 1/2] Fuse2fs: fix 'mount' entry in some cases.
Date: Mon, 8 Oct 2018 17:23:58 -0700	[thread overview]
Message-ID: <20181009002358.GA24099@magnolia> (raw)
In-Reply-To: <20181008233952.20965-2-nicholas.clark@gmail.com>

On Mon, Oct 08, 2018 at 05:39:51PM -0600, nicholas.clark@gmail.com wrote:
> From: Nicholas Clark <nicholas.clark@gmail.com>
> 
> FUSE's parser allows command-line options to be specified before
> or after the device/image and mount-path. This commit changes the
> value of the fsname mount option to be correct even if options are
> specified before the target device/image.
> 
> Signed-off-by: Nicholas Clark <nicholas.clark@gmail.com>

Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>

--D

> ---
>  misc/fuse2fs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/misc/fuse2fs.c b/misc/fuse2fs.c
> index 5c73895e..3214be4a 100644
> --- a/misc/fuse2fs.c
> +++ b/misc/fuse2fs.c
> @@ -3845,7 +3845,7 @@ int main(int argc, char *argv[])
>  	/* Set up default fuse parameters */
>  	snprintf(extra_args, BUFSIZ, "-okernel_cache,subtype=ext4,use_ino,"
>  		 "fsname=%s,attr_timeout=0" FUSE_PLATFORM_OPTS,
> -		 argv[1]);
> +		 fctx.device);
>  	if (fctx.no_default_opts == 0)
>  		fuse_opt_add_arg(&args, extra_args);
>  
> -- 
> 2.17.1
> 

  reply	other threads:[~2018-10-09  7:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-08 23:39 [PATCH 0/2] e2fsprogs: fuse2fs bugfix and new 'fakeroot' feature nicholas.clark
2018-10-08 23:39 ` [PATCH 1/2] Fuse2fs: fix 'mount' entry in some cases nicholas.clark
2018-10-09  0:23   ` Darrick J. Wong [this message]
2018-10-08 23:39 ` [PATCH 2/2] Fuse2fs: add fakeroot option nicholas.clark

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181009002358.GA24099@magnolia \
    --to=darrick.wong@oracle.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=nicholas.clark@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).